Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Unified Diff: media/blink/websourcebuffer_impl.cc

Issue 1727243002: Unify media track info reporting on a demuxer level (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@tracks-impl-in-media
Patch Set: rebase Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/blink/websourcebuffer_impl.cc
diff --git a/media/blink/websourcebuffer_impl.cc b/media/blink/websourcebuffer_impl.cc
index ea09bde707094c6cca6efb24b1689e45c1403408..6b08b1319634b55179767637f8fcb2d0f5df12cd 100644
--- a/media/blink/websourcebuffer_impl.cc
+++ b/media/blink/websourcebuffer_impl.cc
@@ -46,6 +46,9 @@ WebSourceBufferImpl::WebSourceBufferImpl(
client_(NULL),
append_window_end_(kInfiniteDuration()) {
DCHECK(demuxer_);
+ demuxer_->SetTracksWatcher(
wolenetz 2016/03/05 01:47:43 This seems like a method that could be elevated to
+ id, base::Bind(&WebSourceBufferImpl::InitSegmentReceived,
+ base::Unretained(this)));
}
WebSourceBufferImpl::~WebSourceBufferImpl() {
@@ -99,11 +102,8 @@ void WebSourceBufferImpl::append(
unsigned length,
double* timestamp_offset) {
base::TimeDelta old_offset = timestamp_offset_;
- demuxer_->AppendData(id_, data, length,
- append_window_start_, append_window_end_,
- &timestamp_offset_,
- base::Bind(&WebSourceBufferImpl::InitSegmentReceived,
- base::Unretained(this)));
+ demuxer_->AppendData(id_, data, length, append_window_start_,
+ append_window_end_, &timestamp_offset_);
// Coded frame processing may update the timestamp offset. If the caller
// provides a non-NULL |timestamp_offset| and frame processing changes the
@@ -159,7 +159,7 @@ void WebSourceBufferImpl::removedFromMediaSource() {
client_ = NULL;
}
-void WebSourceBufferImpl::InitSegmentReceived(const MediaTracks& tracks) {
+void WebSourceBufferImpl::InitSegmentReceived(scoped_ptr<MediaTracks> tracks) {
DVLOG(1) << __FUNCTION__;
// TODO(servolk): Implement passing MediaTrack info to blink level.
// https://crbug.com/249428

Powered by Google App Engine
This is Rietveld 408576698