Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1450)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/website_settings/website_settings.cc

Issue 1727133002: Expose TLS settings in the Security panel overview, and call out individual obsolete settings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Reintroduce IsSecureTLSCipherSuite() as its negative and update tests. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/ui/browser.cc ('K') | « chrome/browser/ui/browser.cc ('k') | components/security_state/security_state_model.h » ('j') | components/security_state/security_state_model.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/website_settings/website_settings.cc
diff --git a/chrome/browser/ui/website_settings/website_settings.cc b/chrome/browser/ui/website_settings/website_settings.cc
index 0e228700e2a12dce4aba24271451f2b02a32495b..c5f985297a085ef1329983e8e839b964f3c677cc 100644
--- a/chrome/browser/ui/website_settings/website_settings.cc
+++ b/chrome/browser/ui/website_settings/website_settings.cc
@@ -65,6 +65,7 @@
#include "net/cert/cert_status_flags.h"
#include "net/cert/x509_certificate.h"
#include "net/ssl/ssl_cipher_suite_names.h"
+#include "net/ssl/ssl_cipher_suite_names.h"
estark 2016/04/18 11:46:44 Duplicate of the line above it.
lgarron 2016/04/25 23:56:54 Removed.
#include "net/ssl/ssl_connection_status_flags.h"
#include "ui/base/l10n/l10n_util.h"
@@ -545,7 +546,7 @@ void WebsiteSettings::Init(
} else {
site_connection_status_ = SITE_CONNECTION_STATUS_ENCRYPTED;
- if (security_info.is_secure_protocol_and_ciphersuite) {
+ if (security_info.obsolete_ssl_status == net::OBSOLETE_SSL_NONE) {
site_connection_details_.assign(l10n_util::GetStringFUTF16(
IDS_PAGE_INFO_SECURITY_TAB_ENCRYPTED_CONNECTION_TEXT,
subject_name));
« chrome/browser/ui/browser.cc ('K') | « chrome/browser/ui/browser.cc ('k') | components/security_state/security_state_model.h » ('j') | components/security_state/security_state_model.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698