Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js

Issue 1727133002: Expose TLS settings in the Security panel overview, and call out individual obsolete settings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Always expose TLS settings. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js b/third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js
index 2bc3e5f51ccdabe1cbaf2892e73c393dae294821..689a1ddbb08650b0246518adfa88bad3dd420117 100644
--- a/third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js
+++ b/third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js
@@ -547,7 +547,10 @@ WebInspector.SecurityMainView = function(panel)
this._panel = panel;
this._summarySection = this.contentElement.createChild("div", "security-summary");
- this._securityExplanations = this.contentElement.createChild("div", "security-explanation-list");
+
+ // Info explanations should appear after all others.
+ this._securityExplanationsMain = this.contentElement.createChild("div", "security-explanation-list");
+ this._securityExplanationsInfo = this.contentElement.createChild("div", "security-explanation-list");
// Fill the security summary section.
this._summarySection.createChild("div", "security-summary-section-title").textContent = WebInspector.UIString("Security Overview");
@@ -571,7 +574,9 @@ WebInspector.SecurityMainView.prototype = {
*/
_addExplanation: function(explanation)
{
- var explanationSection = this._securityExplanations.createChild("div", "security-explanation");
+ var parent = (explanation.securityState == SecurityAgent.SecurityState.Info) ? this._securityExplanationsInfo : this._securityExplanationsMain;
+
+ var explanationSection = parent.createChild("div", "security-explanation");
explanationSection.classList.add("security-explanation-" + explanation.securityState);
explanationSection.createChild("div", "security-property").classList.add("security-property-" + explanation.securityState);
@@ -621,7 +626,8 @@ WebInspector.SecurityMainView.prototype = {
refreshExplanations: function ()
{
- this._securityExplanations.removeChildren();
+ this._securityExplanationsMain.removeChildren();
+ this._securityExplanationsInfo.removeChildren();
for (var explanation of this._explanations)
this._addExplanation(explanation);

Powered by Google App Engine
This is Rietveld 408576698