chrome/browser/ui/website_settings/website_settings.cc - Issue 1727133002: Expose TLS settings in the Security panel overview, and call out individual obsolete settings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/website_settings/website_settings.cc

Issue 1727133002: Expose TLS settings in the Security panel overview, and call out individual obsolete settings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Also check that connection_status is not zero, which is the case for 3 browser tests. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ssl/chrome_security_state_model_client_browser_tests.cc ('k') | components/security_state/security_state_model.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/website_settings/website_settings.cc

diff --git a/chrome/browser/ui/website_settings/website_settings.cc b/chrome/browser/ui/website_settings/website_settings.cc

index c01a534a8500fe20f759326b0a6a08218deaa9f5..a7fdb5bd01b2da81f641e8ccce78a0e4d604c3ce 100644

--- a/chrome/browser/ui/website_settings/website_settings.cc

+++ b/chrome/browser/ui/website_settings/website_settings.cc

@@ -589,7 +589,7 @@ void WebsiteSettings::Init(

} else {

site_connection_status_ = SITE_CONNECTION_STATUS_ENCRYPTED;

- if (security_info.is_secure_protocol_and_ciphersuite) {

+ if (security_info.obsolete_ssl_status == net::OBSOLETE_SSL_NONE) {

site_connection_details_.assign(l10n_util::GetStringFUTF16(

IDS_PAGE_INFO_SECURITY_TAB_ENCRYPTED_CONNECTION_TEXT,

subject_name));