Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: components/security_state/security_state_model.cc

Issue 1727133002: Expose TLS settings in the Security panel overview, and call out individual obsolete settings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase and update tests. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/security_state/security_state_model.cc
diff --git a/components/security_state/security_state_model.cc b/components/security_state/security_state_model.cc
index 4084402f050039697445c820841a3010ab72a643..7f348797e4a62772b5446c3e98f8e5d63e6d754b 100644
--- a/components/security_state/security_state_model.cc
+++ b/components/security_state/security_state_model.cc
@@ -184,13 +184,9 @@ void SecurityInfoForRequest(
security_info->cert_status = visible_security_state.cert_status;
security_info->scheme_is_cryptographic =
visible_security_state.url.SchemeIsCryptographic();
+ security_info->obsolete_ssl_status =
+ net::ObsoleteSSLStatus(security_info->connection_status);
security_info->pkp_bypassed = visible_security_state.pkp_bypassed;
- security_info->is_secure_protocol_and_ciphersuite =
- (net::SSLConnectionStatusToVersion(security_info->connection_status) >=
- net::SSL_CONNECTION_VERSION_TLS1_2 &&
- net::IsSecureTLSCipherSuite(net::SSLConnectionStatusToCipherSuite(
- security_info->connection_status)));
-
security_info->sct_verify_statuses =
visible_security_state.sct_verify_statuses;
@@ -218,7 +214,7 @@ SecurityStateModel::SecurityInfo::SecurityInfo()
cert_id(0),
security_bits(-1),
connection_status(0),
- is_secure_protocol_and_ciphersuite(false),
+ obsolete_ssl_status(net::OBSOLETE_SSL_NONE),
pkp_bypassed(false) {}
SecurityStateModel::SecurityInfo::~SecurityInfo() {}

Powered by Google App Engine
This is Rietveld 408576698