chrome/browser/ui/browser.cc - Issue 1727133002: Expose TLS settings in the Security panel overview, and call out individual obsolete settings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser.cc

Issue 1727133002: Expose TLS settings in the Security panel overview, and call out individual obsolete settings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add some tests. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ssl/chrome_security_state_model_client_browser_tests.cc ('K') | « chrome/browser/ssl/chrome_security_state_model_client_browser_tests.cc ('k') | chrome/browser/ui/website_settings/website_settings.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/browser.cc

diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc

index 68efa2d089490b8b118011097c787817965206ab..d5b1787a55ea33e0bc0a4deb982d4fce9f15634a 100644

--- a/chrome/browser/ui/browser.cc

+++ b/chrome/browser/ui/browser.cc

@@ -9,6 +9,7 @@

#include <algorithm>

#include <string>

#include <utility>

+#include <vector>

estark 2016/06/15 04:46:09 All these new #includes seem unnecessary since the

lgarron 2016/08/05 23:22:58 Oh my, that's embarrassing. I'm gonna have a stron

#include "base/base_paths.h"

#include "base/bind.h"

@@ -20,6 +21,7 @@

#include "base/process/process_info.h"

#include "base/profiler/scoped_tracker.h"

#include "base/single_thread_task_runner.h"

+#include "base/strings/string16.h"

#include "base/strings/string_number_conversions.h"

#include "base/strings/string_util.h"

#include "base/strings/stringprintf.h"

@@ -208,6 +210,8 @@

#include "net/base/filename_util.h"

#include "net/base/registry_controlled_domains/registry_controlled_domain.h"

#include "net/cookies/cookie_monster.h"

+#include "net/ssl/ssl_cipher_suite_names.h"

+#include "net/ssl/ssl_connection_status_flags.h"

#include "net/url_request/url_request_context.h"

#include "third_party/WebKit/public/web/WebWindowFeatures.h"

#include "ui/base/l10n/l10n_util.h"