Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Unified Diff: chrome/browser/ui/browser.cc

Issue 1727133002: Expose TLS settings in the Security panel overview, and call out individual obsolete settings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser.cc
diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc
index 59da215e8a64393c96e250fa9841a81e9243d2b0..c1fcb56b7713bda752d194075065e81bd3c87573 100644
--- a/chrome/browser/ui/browser.cc
+++ b/chrome/browser/ui/browser.cc
@@ -1401,6 +1401,14 @@ content::SecurityStyle Browser::GetSecurityStyle(
l10n_util::GetStringUTF8(IDS_SECURE_PROTOCOL_AND_CIPHERSUITE),
l10n_util::GetStringUTF8(
IDS_SECURE_PROTOCOL_AND_CIPHERSUITE_DESCRIPTION)));
+ } else {
+ // TODO: Include cipher suite name
+ security_style_explanations->info_explanations.push_back(
+ content::SecurityStyleExplanation(
+ l10n_util::GetStringUTF8(IDS_OBSOLETE_PROTOCOL_AND_CIPHERSUITE),
+ l10n_util::GetStringUTF8(
+ IDS_OBSOLETE_PROTOCOL_AND_CIPHERSUITE_DESCRIPTION))
+ );
estark 2016/02/24 02:10:50 formatting looks weird here
lgarron 2016/04/09 03:22:50 The last I've moved the final ); onto the previous
}
return security_style;

Powered by Google App Engine
This is Rietveld 408576698