Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 1727103002: Revert of Per WebViewScheduler virtual time (Closed)

Created:
4 years, 10 months ago by shrike
Modified:
4 years, 10 months ago
CC:
blink-reviews, blink-reviews-api_chromium.org, blundell+watchlist_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, droger+watchlist_chromium.org, jam, kinuko+watch, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, scheduler-bugs_chromium.org, sdefresne+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Per WebViewScheduler virtual time (patchset #32 id:660001 of https://codereview.chromium.org/1646583002/ ) Reason for revert: Regression: Mac ASan 64 Tests (1) Suspecting this cl for cause of Mac ASan regression, from list of Sheriff-o-matic suggested cls ( https://chromium.googlesource.com/chromium/src/+log/83534ab036f32a6aa7417e64fa3bc37a0b61be9d%5E..24820c067cb649a4eee2387eda8761e776a18d63?pretty=fuller ). https://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests%20(1) Build #12287 - https://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29/builds/12287 [ RUN ] VirtualTimeTest.AllowVirtualTimeToAdvance ../../third_party/WebKit/Source/web/tests/VirtualTimeTest.cpp:103: Failure Value of: ExecuteJavaScript("run_order.join(', ')") Actual: "c, b" Expected: "" Which is: 0x11200a6e0 [ FAILED ] VirtualTimeTest.AllowVirtualTimeToAdvance (60 ms) [2777/2778] VirtualTimeTest.AllowVirtualTimeToAdvance (60 ms) [ RUN ] All/ParameterizedWebFrameTest.DeviceScaleFactorUsesDefaultWithoutViewportTag/0 [ OK ] All/ParameterizedWebFrameTest.DeviceScaleFactorUsesDefaultWithoutViewportTag/0 (65 ms) [2778/2778] All/ParameterizedWebFrameTest.DeviceScaleFactorUsesDefaultWithoutViewportTag/0 (65 ms) Retrying 1 test (retry #2) [ RUN ] VirtualTimeTest.AllowVirtualTimeToAdvance ../../third_party/WebKit/Source/web/tests/VirtualTimeTest.cpp:103: Failure Value of: ExecuteJavaScript("run_order.join(', ')") Actual: "c, b" Expected: "" Which is: 0x10d8e66e0 [ FAILED ] VirtualTimeTest.AllowVirtualTimeToAdvance (62 ms) [2779/2779] VirtualTimeTest.AllowVirtualTimeToAdvance (62 ms) Retrying 1 test (retry #3) [ RUN ] VirtualTimeTest.AllowVirtualTimeToAdvance ../../third_party/WebKit/Source/web/tests/VirtualTimeTest.cpp:103: Failure Value of: ExecuteJavaScript("run_order.join(', ')") Actual: "c, b" Expected: "" Which is: 0x1159e26e0 [ FAILED ] VirtualTimeTest.AllowVirtualTimeToAdvance (61 ms) Original issue's description: > Per WebViewScheduler virtual time. > > This patch introduces a new per WebViewScheduler virtual time and > wires it up into the BlinkTImers. NOTE there will be follow on > patches where various other parts of blink will also use virtual time. > > For determinism some parts of blink will need to use the VirtualTime > although new code should generally use the original non-virtual APIs. > > For more details see: > https://docs.google.com/document/d/1y9KDT_ZEzT7pBeY6uzVt1dgKlwc1OB_vY4NZO1zBQmo/edit# > > BUG=546953 > > Committed: https://crrev.com/0d2d2840ad6d7f149569eb42332c8c8083401234 > Cr-Commit-Position: refs/heads/master@{#377094} TBR=esprehn@chromium.org,skyostil@chromium.org,alexclarke@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=546953 Committed: https://crrev.com/dfbf0696b713398f9e30cb5db74aae5c1b6d25fa Cr-Commit-Position: refs/heads/master@{#377181}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -275 lines) Patch
M components/scheduler/child/web_task_runner_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M components/scheduler/child/web_task_runner_impl.cc View 2 chunks +0 lines, -11 lines 0 comments Download
M components/scheduler/renderer/renderer_scheduler.h View 1 chunk +12 lines, -0 lines 0 comments Download
M components/scheduler/renderer/renderer_scheduler_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M components/scheduler/renderer/renderer_scheduler_impl.cc View 1 chunk +21 lines, -0 lines 0 comments Download
M components/scheduler/renderer/web_view_scheduler_impl.h View 1 chunk +4 lines, -2 lines 0 comments Download
M components/scheduler/renderer/web_view_scheduler_impl_unittest.cc View 5 chunks +28 lines, -42 lines 0 comments Download
M content/test/fake_renderer_scheduler.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/test/fake_renderer_scheduler.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/DOMTimer.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/DOMTimer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/Timer.h View 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/Timer.cpp View 4 chunks +5 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/platform/TimerTest.cpp View 6 chunks +18 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurfaceTest.cpp View 1 chunk +0 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/platform/testing/TestingPlatformSupport.cpp View 1 chunk +0 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.h View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/Source/web/tests/VirtualTimeTest.cpp View 1 chunk +0 lines, -111 lines 0 comments Download
M third_party/WebKit/Source/web/web.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/public/platform/WebTaskRunner.h View 1 chunk +0 lines, -18 lines 0 comments Download
M third_party/WebKit/public/platform/WebViewScheduler.h View 1 chunk +0 lines, -19 lines 0 comments Download
M third_party/WebKit/public/web/WebView.h View 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
shrike
Created Revert of Per WebViewScheduler virtual time
4 years, 10 months ago (2016-02-24 01:26:59 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1727103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1727103002/1
4 years, 10 months ago (2016-02-24 01:28:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1727103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1727103002/1
4 years, 10 months ago (2016-02-24 01:35:01 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-24 01:40:46 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2016-02-24 01:41:46 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dfbf0696b713398f9e30cb5db74aae5c1b6d25fa
Cr-Commit-Position: refs/heads/master@{#377181}

Powered by Google App Engine
This is Rietveld 408576698