Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1727033004: Gn: remove redundant prefix setting code. (Closed)

Created:
4 years, 10 months ago by dshwang
Modified:
4 years, 10 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, agrieve
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Gn: remove redundant prefix setting code. Reuse |android_tool_prefix| in //build/toolchain/gcc_toolchain.gni Committed: https://crrev.com/c672f32e43d852e054f9823e78b410d7638b906e Cr-Commit-Position: refs/heads/master@{#377965}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -11 lines) Patch
M build/toolchain/android/BUILD.gn View 9 chunks +1 line, -11 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
dshwang
Dirk, could you review?
4 years, 10 months ago (2016-02-26 14:56:24 UTC) #3
Dirk Pranke
lgtm
4 years, 10 months ago (2016-02-26 18:44:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1727033004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1727033004/1
4 years, 10 months ago (2016-02-26 19:53:13 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-26 20:47:20 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-26 20:48:55 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/c672f32e43d852e054f9823e78b410d7638b906e
Cr-Commit-Position: refs/heads/master@{#377965}

Powered by Google App Engine
This is Rietveld 408576698