Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1168)

Unified Diff: components/safe_browsing_db/BUILD.gn

Issue 1727033003: v4_update_protocol_manager: Basic implementation with TODOs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Incorporate review feedback. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/safe_browsing_db.gypi ('k') | components/safe_browsing_db/v4_get_hash_protocol_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/safe_browsing_db/BUILD.gn
diff --git a/components/safe_browsing_db/BUILD.gn b/components/safe_browsing_db/BUILD.gn
index f1154f7e7391acac69b94d02e70c3743d1a0f716..975861afb5e276ee29ca8b35fb71c47db8b8c57e 100644
--- a/components/safe_browsing_db/BUILD.gn
+++ b/components/safe_browsing_db/BUILD.gn
@@ -51,6 +51,7 @@ source_set("database_manager") {
":hit_report",
":util",
":v4_get_hash_protocol_manager",
+ ":v4_update_protocol_manager",
"//base:base",
"//content/public/browser",
"//content/public/common",
@@ -123,6 +124,18 @@ source_set("safe_browsing_api_handler_util") {
]
}
+source_set("test_database_manager") {
+ sources = [
+ "test_database_manager.cc",
+ "test_database_manager.h",
+ ]
+ deps = [
+ ":database_manager",
+ "//base:base",
+ "//net",
+ ]
+}
+
source_set("util") {
sources = [
"util.cc",
@@ -130,8 +143,10 @@ source_set("util") {
]
deps = [
"//base",
+ "//base:base",
"//crypto",
"//net",
+ "//url:url",
]
if (is_win) {
# TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
@@ -139,18 +154,6 @@ source_set("util") {
}
}
-source_set("test_database_manager") {
- sources = [
- "test_database_manager.cc",
- "test_database_manager.h",
- ]
- deps = [
- ":database_manager",
- "//base:base",
- "//net",
- ]
-}
-
source_set("v4_get_hash_protocol_manager") {
sources = [
"v4_get_hash_protocol_manager.cc",
@@ -174,6 +177,22 @@ source_set("v4_protocol_manager_util") {
"v4_protocol_manager_util.h",
]
deps = [
+ ":proto",
+ "//base",
+ "//net",
+ "//url:url",
+ ]
+}
+
+source_set("v4_update_protocol_manager") {
+ sources = [
+ "v4_update_protocol_manager.cc",
+ "v4_update_protocol_manager.h",
+ ]
+ deps = [
+ ":proto",
+ ":util",
+ ":v4_protocol_manager_util",
"//base",
"//net",
"//url:url",
@@ -187,6 +206,7 @@ source_set("unit_tests") {
"util_unittest.cc",
"v4_get_hash_protocol_manager_unittest.cc",
"v4_protocol_manager_util_unittest.cc",
+ "v4_update_protocol_manager_unittest.cc",
]
deps = [
":prefix_set",
@@ -194,6 +214,7 @@ source_set("unit_tests") {
":util",
":v4_get_hash_protocol_manager",
":v4_protocol_manager_util",
+ ":v4_update_protocol_manager",
"//base",
"//net",
"//net:test_support",
« no previous file with comments | « components/safe_browsing_db.gypi ('k') | components/safe_browsing_db/v4_get_hash_protocol_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698