Issue 1727021: Fix types that reached into WebCore and busted deps roll....

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1727021: Fix types that reached into WebCore and busted deps roll.... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
5 years, 1 month ago by slightlyoff

Modified:
4 years ago

Reviewers:
jamesr, ananta

CC:
chromium-reviews, amit

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Fix types that reached into WebCore and busted deps roll. TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=46175

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -7 lines)			Patch
M	chrome_frame/np_browser_functions.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome_frame/np_browser_functions.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome_frame/np_proxy_service.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome_frame/npapi_url_request.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Trybot results: mac linux win

Total messages: 2 (0 generated)

LGTM (fwiw)