Issue 1727003002: Replace the now missing ContextAttributes with our previously Firefox-only _TypedContextAttributes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1727003002: Replace the now missing ContextAttributes with our previously Firefox-only _TypedContextAttributes (Closed)

Created:
4 years, 10 months ago by Alan Knight

Modified:
4 years, 10 months ago

Reviewers:
terry, Jacob

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Replace the now missing ContextAttributes with our previously Firefox-only _TypedContextAttributes BUG= R=jacobr@google.com Committed: https://github.com/dart-lang/sdk/commit/78b0f6f353b5349a50c3e38ef5f44ded1f7e1ee4

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	sdk/lib/html/html_common/conversions.dart	View		3 chunks	+3 lines, -3 lines	0 comments	Download
	M	tools/dom/scripts/dartmetadata.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (2 generated)

Alan Knight

I think we can just rename _TypedContextAttributes to ContextAttributes and always use it. Actually, it ...

4 years, 10 months ago (2016-02-23 23:24:18 UTC) #2

Alan Knight

4 years, 10 months ago (2016-02-24 00:33:36 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
78b0f6f353b5349a50c3e38ef5f44ded1f7e1ee4.