Remove FXSYS_MulDiv(a, b, c).

Remove FXSYS_MulDiv(a, b, c).

This is a wrapper which does (a) * (b) / (c). Inline the operations.

R=thestig@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/435604d371de48044ae6c1567479b34e0d93e298

[dsinclair, 2016-02-23 21:00:01]

dsinclair@chromium.org changed reviewers:
+ thestig@chromium.org, tsepez@chromium.org

[dsinclair, 2016-02-23 21:00:02]

PTAL.

[Lei Zhang, 2016-02-23 21:22:40]

lgtm

https://codereview.chromium.org/1726893002/diff/20001/core/src/fpdfapi/fpdf_r...
File core/src/fpdfapi/fpdf_render/fpdf_render_pattern.cpp (right):

https://codereview.chromium.org/1726893002/diff/20001/core/src/fpdfapi/fpdf_r...
core/src/fpdfapi/fpdf_render/fpdf_render_pattern.cpp:358: r[nIntersects] =
vertex1.r + ((vertex2.r - vertex1.r) * (y - vertex1.y) /
Calculate (y - vertex1.y) / (vertex2.y - vertex1.y) once and use the result in
the RGB calculations?

[dsinclair, 2016-02-23 21:31:27]

https://codereview.chromium.org/1726893002/diff/20001/core/src/fpdfapi/fpdf_r...
File core/src/fpdfapi/fpdf_render/fpdf_render_pattern.cpp (right):

https://codereview.chromium.org/1726893002/diff/20001/core/src/fpdfapi/fpdf_r...
core/src/fpdfapi/fpdf_render/fpdf_render_pattern.cpp:358: r[nIntersects] =
vertex1.r + ((vertex2.r - vertex1.r) * (y - vertex1.y) /
On 2016/02/23 21:22:40, Lei Zhang wrote:
> Calculate (y - vertex1.y) / (vertex2.y - vertex1.y) once and use the result in
> the RGB calculations?

Done.

[dsinclair, 2016-02-23 21:31:47]

Description was changed from

==========
Remove FXSYS_MulDiv(a, b, c).

This is a wrapper which does (a) * (b) / (c). Inline the operations.
==========

to

==========
Remove FXSYS_MulDiv(a, b, c).

This is a wrapper which does (a) * (b) / (c). Inline the operations.

R=thestig@chromium.org

Committed:
https://pdfium.googlesource.com/pdfium/+/435604d371de48044ae6c1567479b34e0d93...
==========

[dsinclair, 2016-02-23 21:31:48]

Committed patchset #3 (id:40001) manually as
435604d371de48044ae6c1567479b34e0d93e298 (presubmit successful).

[Tom Sepez, 2016-02-23 23:40:12]

https://codereview.chromium.org/1726893002/diff/40001/core/include/fxcrt/fx_s...
File core/include/fxcrt/fx_system.h (right):

https://codereview.chromium.org/1726893002/diff/40001/core/include/fxcrt/fx_s...
core/include/fxcrt/fx_system.h:272: #define FXSYS_sqrt2(a, b) (FX_FLOAT)
FXSYS_sqrt((a) * (a) + (b) * (b))
Nit: Let's someday make this a function rather than a macro to avoid
mulit-evaluation, like all the others here.