Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(687)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: base/metrics/histogram_persistence.cc

Issue 1726873002: Report histogram creation results. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: some 'git cl format' changes Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/metrics/histogram_base_unittest.cc ('K') | « base/metrics/histogram_base_unittest.cc ('k') | base/metrics/sparse_histogram.cc » ('j') | base/metrics/statistics_recorder.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/metrics/histogram_persistence.cc
diff --git a/base/metrics/histogram_persistence.cc b/base/metrics/histogram_persistence.cc
index f18d17528354329cd4995615d2451f6a52c59302..c6464e1250fe666598eeeb43ca6df86e26c69ac3 100644
--- a/base/metrics/histogram_persistence.cc
+++ b/base/metrics/histogram_persistence.cc
@@ -187,6 +187,12 @@ void SetPersistentHistogramMemoryAllocator(
// also released, future accesses to those histograms will seg-fault.
CHECK(!g_allocator);
g_allocator = allocator;
+
+ size_t existing = StatisticsRecorder::NumberOfHistograms();
+ if (existing) {
Alexei Svitkine (slow) 2016/03/01 16:41:34 Nit: != 0 for checking numbers.
bcwhite 2016/03/02 19:14:19 Done.
+ DLOG(WARNING) << existing
+ << " histograms were created before persistence was enabled.";
+ }
}
PersistentMemoryAllocator* GetPersistentHistogramMemoryAllocator() {
« base/metrics/histogram_base_unittest.cc ('K') | « base/metrics/histogram_base_unittest.cc ('k') | base/metrics/sparse_histogram.cc » ('j') | base/metrics/statistics_recorder.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698