Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1939)

Unified Diff: chrome/installer/setup/installer_metrics.cc

Issue 1726873002: Report histogram creation results. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: added message for why not using macro Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/setup/installer_metrics.cc
diff --git a/chrome/installer/setup/installer_metrics.cc b/chrome/installer/setup/installer_metrics.cc
index 8e5f0443e437f7589493be0818c56ef397cf2b17..5826b1c4b6372f7a0bb3245d3469a9b616d89ce6 100644
--- a/chrome/installer/setup/installer_metrics.cc
+++ b/chrome/installer/setup/installer_metrics.cc
@@ -21,6 +21,10 @@ void BeginPersistentHistogramStorage() {
installer::kSetupHistogramAllocatorName));
base::GetPersistentHistogramMemoryAllocator()->CreateTrackingHistograms(
installer::kSetupHistogramAllocatorName);
+
+ // This can't be enabled until after the allocator is configured because
+ // there is no other reporting out of setup other than persistent memory.
+ base::HistogramBase::EnableActivityReportHistogram("setup");
}
void EndPersistentHistogramStorage(const base::FilePath& target_path) {

Powered by Google App Engine
This is Rietveld 408576698