Report histogram creation results.

base/metrics/histogram_base.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/metrics/histogram_base.h"
 
 #include <limits.h>
 
 #include <utility>
 
@@ skipping 44 matching lines @@
     case CUSTOM_HISTOGRAM:
       return CustomHistogram::DeserializeInfoImpl(iter);
     case SPARSE_HISTOGRAM:
       return SparseHistogram::DeserializeInfoImpl(iter);
     default:
       return NULL;
   }
 }
 
 const HistogramBase::Sample HistogramBase::kSampleType_MAX = INT_MAX;
+HistogramBase* HistogramBase::report_histogram_ = nullptr;
 
 HistogramBase::HistogramBase(const std::string& name)
     : histogram_name_(name),
       flags_(kNoFlags) {}
 
 HistogramBase::~HistogramBase() {}
 
 void HistogramBase::CheckName(const StringPiece& name) const {
   DCHECK_EQ(histogram_name(), name);
 }
@@ skipping 40 matching lines @@
   root.SetString("name", histogram_name());
   root.SetInteger("count", count);
   root.SetDouble("sum", static_cast<double>(sum));
   root.SetInteger("flags", flags());
   root.Set("params", std::move(parameters));
   root.Set("buckets", std::move(buckets));
   root.SetInteger("pid", GetCurrentProcId());
   serializer.Serialize(root);
 }
 
+// static
+void HistogramBase::EnableCreationReportHistogram(StringPiece process_type) {
+  DCHECK(!report_histogram_);
+  size_t existing = StatisticsRecorder::NumberOfHistograms();
+  if (existing) {

[Alexei Svitkine (slow), 2016/03/01 16:41:33]

Nit: != 0

[bcwhite, 2016/03/02 19:14:19]

Done.

+    DLOG(WARNING) << existing
+                  << " histograms were created before reporting was enabled.";
+  }
+
+  std::string name =
+      "UMA.Histograms." + process_type.as_string() + ".Creations";
+  report_histogram_ = LinearHistogram::FactoryGet(
+      name, 1, HISTOGRAM_REPORT_MAX, HISTOGRAM_REPORT_MAX + 1,
+      kUmaTargetedHistogramFlag);
+  report_histogram_->Add(HISTOGRAM_REPORT_CREATED);
+}
+
 void HistogramBase::FindAndRunCallback(HistogramBase::Sample sample) const {
   if ((flags() & kCallbackExists) == 0)
     return;
 
   StatisticsRecorder::OnSampleCallback cb =
       StatisticsRecorder::FindCallback(histogram_name());
   if (!cb.is_null())
     cb.Run(sample);
 }
 
@@ skipping 21 matching lines @@
     StringAppendF(&result, "%d", sample);
   return result;
 }
 
 void HistogramBase::WriteAsciiBucketValue(Count current,
                                           double scaled_sum,
                                           std::string* output) const {
   StringAppendF(output, " (%d = %3.1f%%)", current, current/scaled_sum);
 }
 
+// static
+void HistogramBase::UpdateReportHistogram(HistogramBase* histogram,
+                                          bool created) {
+  if (!report_histogram_)
+    return;
+
+  if (created) {
+    report_histogram_->Add(HISTOGRAM_REPORT_HISTOGRAM_CREATED);
+    report_histogram_->Add(HISTOGRAM_REPORT_TYPE_GENERAL +
+                           histogram->GetHistogramType());

[Alexei Svitkine (slow), 2016/03/01 16:41:34]

This is a bit fragile - if the histogram type ever changes (a new value is
added), then this histogram gets broken.

I suggest just doing a switch on the histogram type and mapping to the value.
This way, if a new type is added, then there would be a compile error if there's
a new enum that's not handled in the switch - which ensures that the histogram
will be updated.

[bcwhite, 2016/03/02 19:14:19]

Done.

+    const int32_t flags = histogram->flags_;
+    if (flags & kIsPersistent)
+      report_histogram_->Add(HISTOGRAM_REPORT_FLAG_PERSISTENT);
+    if (flags & (kUmaStabilityHistogramFlag & ~kUmaTargetedHistogramFlag))
+      report_histogram_->Add(HISTOGRAM_REPORT_FLAG_UMA_STABILITY);
+    else if (flags & kUmaTargetedHistogramFlag)
+      report_histogram_->Add(HISTOGRAM_REPORT_FLAG_UMA_TARGETED);
+  } else {
+    report_histogram_->Add(HISTOGRAM_REPORT_HISTOGRAM_LOOKUP);
+  }
+}
+
 }  // namespace base