Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Side by Side Diff: chrome/installer/setup/installer_metrics.cc

Issue 1726873002: Report histogram creation results. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/metrics/statistics_recorder.cc ('k') | content/app/content_main_runner.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/installer/setup/installer_metrics.h" 5 #include "chrome/installer/setup/installer_metrics.h"
6 6
7 #include "base/files/file.h" 7 #include "base/files/file.h"
8 #include "base/files/file_path.h" 8 #include "base/files/file_path.h"
9 #include "base/files/file_util.h" 9 #include "base/files/file_util.h"
10 #include "base/metrics/histogram_base.h" 10 #include "base/metrics/histogram_base.h"
11 #include "base/metrics/persistent_histogram_allocator.h" 11 #include "base/metrics/persistent_histogram_allocator.h"
12 #include "base/metrics/persistent_memory_allocator.h" 12 #include "base/metrics/persistent_memory_allocator.h"
13 #include "chrome/installer/util/util_constants.h" 13 #include "chrome/installer/util/util_constants.h"
14 14
15 namespace installer { 15 namespace installer {
16 16
17 void BeginPersistentHistogramStorage() { 17 void BeginPersistentHistogramStorage() {
18 base::PersistentHistogramAllocator::CreateGlobalAllocatorOnLocalMemory( 18 base::PersistentHistogramAllocator::CreateGlobalAllocatorOnLocalMemory(
19 1 << 20, // 1 MiB 19 1 << 20, // 1 MiB
20 0, // No identifier. 20 0, // No identifier.
21 installer::kSetupHistogramAllocatorName); 21 installer::kSetupHistogramAllocatorName);
22 base::PersistentHistogramAllocator::GetGlobalAllocator() 22 base::PersistentHistogramAllocator::GetGlobalAllocator()
23 ->CreateTrackingHistograms(installer::kSetupHistogramAllocatorName); 23 ->CreateTrackingHistograms(installer::kSetupHistogramAllocatorName);
24
25 // This can't be enabled until after the allocator is configured because
26 // there is no other reporting out of setup other than persistent memory.
27 base::HistogramBase::EnableActivityReportHistogram("setup");
24 } 28 }
25 29
26 void EndPersistentHistogramStorage(const base::FilePath& target_path) { 30 void EndPersistentHistogramStorage(const base::FilePath& target_path) {
27 base::PersistentHistogramAllocator* allocator = 31 base::PersistentHistogramAllocator* allocator =
28 base::PersistentHistogramAllocator::GetGlobalAllocator(); 32 base::PersistentHistogramAllocator::GetGlobalAllocator();
29 allocator->UpdateTrackingHistograms(); 33 allocator->UpdateTrackingHistograms();
30 34
31 // For atomicity, first write to a temporary file and then rename it. 35 // For atomicity, first write to a temporary file and then rename it.
32 // The ImportantFileWriter would be good for this except it supports only 36 // The ImportantFileWriter would be good for this except it supports only
33 // std::string for its data. 37 // std::string for its data.
(...skipping 12 matching lines...) Expand all
46 if (base::ReplaceFile(tmp_file_path, file_path, nullptr)) { 50 if (base::ReplaceFile(tmp_file_path, file_path, nullptr)) {
47 VLOG(1) << "Persistent histograms saved in file: " 51 VLOG(1) << "Persistent histograms saved in file: "
48 << file_path.value(); 52 << file_path.value();
49 } 53 }
50 } 54 }
51 base::DeleteFile(tmp_file_path, false); 55 base::DeleteFile(tmp_file_path, false);
52 } 56 }
53 } 57 }
54 58
55 } // namespace installer 59 } // namespace installer
OLDNEW
« no previous file with comments | « base/metrics/statistics_recorder.cc ('k') | content/app/content_main_runner.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698