Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 1726853002: Revert of iOS: Fix condition for use_analyze in ios recipe module. (Closed)

Created:
4 years, 10 months ago by kjellander_chromium
Modified:
4 years, 10 months ago
Reviewers:
smut
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/remotes/origin/master
Project:
build
Visibility:
Public.

Description

Revert of iOS: Fix condition for use_analyze in ios recipe module. (patchset #1 id:1 of https://codereview.chromium.org/1723033003/ ) Reason for revert: Proper fix is done in the JSON files in https://codereview.webrtc.org/1728743002/ which now is landed. Reverting this. Original issue's description: > iOS: Fix condition for use_analyze in ios recipe module. > > Turns out the default value (enabled) is True, but when > use_analyze is set to 'false' in the JSON, the value becomes > a string 'false'. Fix this by changing the condition check. > > This caused the WebRTC trybots to always use analyze, which > is not supported (fails). > > TBR=smut@google.com > BUG=588590 > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298919 TBR=smut@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=588590 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298928

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M scripts/slave/recipe_modules/ios/api.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
kjellander_chromium
Created Revert of iOS: Fix condition for use_analyze in ios recipe module.
4 years, 10 months ago (2016-02-23 20:26:29 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1726853002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1726853002/1
4 years, 10 months ago (2016-02-23 20:26:32 UTC) #2
commit-bot: I haz the power
4 years, 10 months ago (2016-02-23 20:26:42 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=298928

Powered by Google App Engine
This is Rietveld 408576698