src/codec/SkCodec.cpp - Issue 1726823002: Set SkColorSpace object for PNGs and parse ICC profiles

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/codec/SkCodec.cpp

Issue 1726823002: Set SkColorSpace object for PNGs and parse ICC profiles (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Refactored a bit, added guesses for "default" gAMA/cHRM Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/codec/SkCodec.cpp

diff --git a/src/codec/SkCodec.cpp b/src/codec/SkCodec.cpp

index d7cfb3749708f04e4f3d2adba765c82205dce4f3..9c66275101688920f8446db0b25ea9e5a0fdad71 100644

--- a/src/codec/SkCodec.cpp

+++ b/src/codec/SkCodec.cpp

@@ -113,10 +113,11 @@ SkCodec* SkCodec::NewFromData(SkData* data, SkPngChunkReader* reader) {

return NewFromStream(new SkMemoryStream(data), reader);

}

-SkCodec::SkCodec(const SkImageInfo& info, SkStream* stream)

+SkCodec::SkCodec(const SkImageInfo& info, SkStream* stream, SkColorSpace* colorSpace)

: fSrcInfo(info)

, fStream(stream)

, fNeedsRewind(false)

+ , fColorSpace(colorSpace)

, fDstInfo()

, fOptions()

, fCurrScanline(-1)