gyp/tools.gyp - Issue 1726823002: Set SkColorSpace object for PNGs and parse ICC profiles

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gyp/tools.gyp

Issue 1726823002: Set SkColorSpace object for PNGs and parse ICC profiles (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Response to comments from Patch Set 7 Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gyp/tools.gyp

diff --git a/gyp/tools.gyp b/gyp/tools.gyp

index f5e61091a7bf24cb1fc6e90a5fd594fed7579d0b..2e139167f11cdfde03aeeacea74e3b293a974ade 100644

--- a/gyp/tools.gyp

+++ b/gyp/tools.gyp

@@ -266,15 +266,18 @@

{

- 'target_name': 'get_images_from_skps',

- 'type': 'executable',

- 'sources': [

- '../tools/get_images_from_skps.cpp',

- ],

- 'dependencies': [

- 'flags.gyp:flags',

- 'skia_lib.gyp:skia_lib',

- ],

+ 'target_name': 'get_images_from_skps',

+ 'type': 'executable',

+ 'sources': [

+ '../tools/get_images_from_skps.cpp',

+ ],

+ 'include_dirs': [

+ '../src/core',

+ ],

+ 'dependencies': [

+ 'flags.gyp:flags',

+ 'skia_lib.gyp:skia_lib',

+ ],

{

'target_name': 'gpuveto',

@@ -489,6 +492,7 @@

'include_dirs': [

'<@(includes_to_test)',

+ '../src/core',

'sources': [

# unused_param_test.cpp is generated by the action below.