Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1726803002: Remove more _CAPS names (Closed)

Created:
4 years, 10 months ago by Tom Sepez
Modified:
4 years, 10 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+276 lines, -244 lines) Patch
M core/src/fpdfdoc/doc_form.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxge/apple/apple_int.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/include/fwl/basewidget/fwl_edit.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/include/fwl/basewidget/fwl_listbox.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/include/fwl/core/fwl_grid.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/include/fwl/core/fwl_thread.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/include/fwl/core/fwl_timer.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/include/fxjse/fxjse.h View 3 chunks +9 lines, -8 lines 0 comments Download
M xfa/src/fdp/include/fde_brs.h View 1 chunk +2 lines, -3 lines 0 comments Download
M xfa/src/fdp/include/fde_img.h View 2 chunks +22 lines, -21 lines 0 comments Download
M xfa/src/fdp/include/fde_pen.h View 1 chunk +7 lines, -3 lines 0 comments Download
M xfa/src/fdp/include/fde_psr.h View 2 chunks +3 lines, -3 lines 0 comments Download
M xfa/src/fdp/include/fde_rdv.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fdp/include/fde_xml.h View 4 chunks +14 lines, -18 lines 0 comments Download
M xfa/src/fdp/src/css/fde_csscache.h View 3 chunks +16 lines, -12 lines 0 comments Download
M xfa/src/fdp/src/css/fde_csscache.cpp View 5 chunks +7 lines, -7 lines 0 comments Download
M xfa/src/fdp/src/css/fde_cssdeclaration.h View 5 chunks +34 lines, -32 lines 0 comments Download
M xfa/src/fdp/src/css/fde_cssdeclaration.cpp View 35 chunks +66 lines, -58 lines 0 comments Download
M xfa/src/fdp/src/css/fde_cssstyleselector.h View 6 chunks +32 lines, -26 lines 0 comments Download
M xfa/src/fdp/src/css/fde_cssstyleselector.cpp View 9 chunks +17 lines, -17 lines 0 comments Download
M xfa/src/fdp/src/fde/fde_iterator.h View 1 chunk +3 lines, -2 lines 0 comments Download
M xfa/src/fdp/src/fde/fde_iterator.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/src/fdp/src/xml/fde_xml_imp.h View 3 chunks +3 lines, -3 lines 0 comments Download
M xfa/src/fdp/src/xml/fde_xml_imp.cpp View 6 chunks +9 lines, -6 lines 0 comments Download
M xfa/src/fee/include/ifde_txtedtengine.h View 3 chunks +6 lines, -1 line 0 comments Download
M xfa/src/fee/src/fee/fde_txtedtpage.h View 1 chunk +4 lines, -2 lines 0 comments Download
M xfa/src/fee/src/fee/fde_txtedtpage.cpp View 12 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Tom Sepez
Lei, part 2 for review.
4 years, 10 months ago (2016-02-23 19:16:22 UTC) #2
Lei Zhang
lgtm
4 years, 10 months ago (2016-02-23 19:33:30 UTC) #3
Tom Sepez
4 years, 10 months ago (2016-02-23 20:09:30 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
2886a25b68225ad3ad70d417b01108ad1d126488 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698