Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1726783002: Copy adb_profile_chrome to catapult (Closed)

Created:
4 years, 10 months ago by Zhen Wang
Modified:
4 years, 10 months ago
Reviewers:
sullivan, Sami
CC:
catapult-reviews_chromium.org
Base URL:
https://github.com/catapult-project/catapult.git@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Copy adb_profile_chrome to catapult This CL copies [chromium-src]/tools/profile_chrome to Catapult. The next CL will remove profile_chrome in Chromium. Tests are not added to the trybots because the Android trybot is not ready yet. Will add them later. BUG=catapult:#1937 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/bb6eef7565d7764697a750271262ea44c336fb84

Patch Set 1 : copy //tools/profile_chrome/ #

Patch Set 2 : fix dependency and presubmit warnings #

Patch Set 3 : copy profile_chrome_startup and fix dependency #

Patch Set 4 : add OWNERS file to bin files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1797 lines, -24 lines) Patch
M systrace/PRESUBMIT.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
A systrace/bin/OWNERS View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
A systrace/bin/adb_profile_chrome View 1 1 chunk +14 lines, -0 lines 0 comments Download
A systrace/bin/adb_profile_chrome_startup View 1 2 1 chunk +106 lines, -0 lines 0 comments Download
A systrace/profile_chrome/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
A systrace/profile_chrome/__init__.py View 1 1 chunk +10 lines, -0 lines 0 comments Download
A systrace/profile_chrome/chrome_controller.py View 1 chunk +115 lines, -0 lines 0 comments Download
A systrace/profile_chrome/chrome_controller_unittest.py View 1 chunk +41 lines, -0 lines 0 comments Download
A systrace/profile_chrome/chrome_startup_controller.py View 1 1 chunk +72 lines, -0 lines 0 comments Download
A systrace/profile_chrome/chrome_startup_controller_unittest.py View 1 chunk +28 lines, -0 lines 0 comments Download
A systrace/profile_chrome/controllers.py View 1 1 chunk +17 lines, -0 lines 0 comments Download
A systrace/profile_chrome/controllers_unittest.py View 1 chunk +24 lines, -0 lines 0 comments Download
A systrace/profile_chrome/ddms_controller.py View 1 chunk +54 lines, -0 lines 0 comments Download
A systrace/profile_chrome/ddms_controller_unittest.py View 1 chunk +26 lines, -0 lines 0 comments Download
A systrace/profile_chrome/flags.py View 1 chunk +26 lines, -0 lines 0 comments Download
A systrace/profile_chrome/main.py View 1 1 chunk +267 lines, -0 lines 0 comments Download
A systrace/profile_chrome/perf_controller.py View 1 1 chunk +189 lines, -0 lines 0 comments Download
A systrace/profile_chrome/perf_controller_unittest.py View 1 chunk +40 lines, -0 lines 0 comments Download
A systrace/profile_chrome/profiler.py View 1 1 chunk +88 lines, -0 lines 0 comments Download
A systrace/profile_chrome/profiler_unittest.py View 1 chunk +78 lines, -0 lines 0 comments Download
A systrace/profile_chrome/run_tests View 1 chunk +3 lines, -0 lines 0 comments Download
A systrace/profile_chrome/systrace_controller.py View 1 chunk +112 lines, -0 lines 0 comments Download
A systrace/profile_chrome/systrace_controller_unittest.py View 1 chunk +37 lines, -0 lines 0 comments Download
A + systrace/profile_chrome/third_party/COPYING View 11 chunks +21 lines, -22 lines 0 comments Download
A systrace/profile_chrome/third_party/README.chromium View 1 chunk +15 lines, -0 lines 0 comments Download
A systrace/profile_chrome/third_party/perf_to_tracing.py View 1 chunk +248 lines, -0 lines 0 comments Download
A systrace/profile_chrome/trace_packager.py View 1 1 chunk +93 lines, -0 lines 0 comments Download
A systrace/profile_chrome/trace_packager_unittest.py View 1 chunk +35 lines, -0 lines 0 comments Download
A systrace/profile_chrome/ui.py View 1 1 chunk +27 lines, -0 lines 0 comments Download
A + systrace/profile_chrome/util.py View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Zhen Wang
ptal
4 years, 10 months ago (2016-02-23 20:01:05 UTC) #3
Sami
lgtm, yay!
4 years, 10 months ago (2016-02-24 12:15:52 UTC) #6
Zhen Wang
+sullivan for owner stamp. :)
4 years, 10 months ago (2016-02-24 16:19:35 UTC) #8
sullivan
lgtm
4 years, 10 months ago (2016-02-24 16:44:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1726783002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1726783002/60001
4 years, 10 months ago (2016-02-24 17:46:46 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2016-02-24 18:03:19 UTC) #13
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698