Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1674)

Unified Diff: runtime/observatory/tests/service/async_scope_test.dart

Issue 1726773002: Refactor service tests in preparation of running on sky_shell (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/tests/service/async_scope_test.dart
diff --git a/runtime/observatory/tests/service/async_scope_test.dart b/runtime/observatory/tests/service/async_scope_test.dart
index a3f97cc4d456ebb98e2bf0aadcea08c74b9efdd1..170a638b7c26709c81ee884a54bf3b025947599c 100644
--- a/runtime/observatory/tests/service/async_scope_test.dart
+++ b/runtime/observatory/tests/service/async_scope_test.dart
@@ -6,19 +6,23 @@
import 'dart:developer';
import 'package:observatory/service_io.dart';
import 'package:unittest/unittest.dart';
+import 'service_test_common.dart';
import 'test_helper.dart';
+const int LINE_A = 19;
+const int LINE_B = 25;
+
foo() {}
doAsync(param1) async {
var local1 = param1 + 1;
- foo(); // Line 15
+ foo(); // Line A.
await local1;
}
doAsyncStar(param2) async* {
var local2 = param2 + 1;
- foo(); // Line 21
+ foo(); // Line B.
yield local2;
}
@@ -53,17 +57,17 @@ checkAsyncStarVarDescriptors(Isolate isolate) async {
var tests = [
hasStoppedAtBreakpoint, // debugger()
- setBreakpointAtLine(15),
- setBreakpointAtLine(21),
+ setBreakpointAtLine(LINE_A),
+ setBreakpointAtLine(LINE_B),
resumeIsolate,
hasStoppedAtBreakpoint,
- stoppedAtLine(15),
+ stoppedAtLine(LINE_A),
checkAsyncVarDescriptors,
resumeIsolate,
hasStoppedAtBreakpoint,
- stoppedAtLine(21),
+ stoppedAtLine(LINE_B),
checkAsyncStarVarDescriptors,
resumeIsolate,
];
« no previous file with comments | « runtime/observatory/tests/service/async_next_test.dart ('k') | runtime/observatory/tests/service/break_on_function_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698