Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Unified Diff: runtime/observatory/tests/service/parameters_in_scope_at_entry_test.dart

Issue 1726773002: Refactor service tests in preparation of running on sky_shell (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/tests/service/parameters_in_scope_at_entry_test.dart
diff --git a/runtime/observatory/tests/service/parameters_in_scope_at_entry_test.dart b/runtime/observatory/tests/service/parameters_in_scope_at_entry_test.dart
index 0e4209afdd7d49932ad46a0456bd16a354ddf4ca..7f90eec36b764663ee6d2e0025eae95bbce902ea 100644
--- a/runtime/observatory/tests/service/parameters_in_scope_at_entry_test.dart
+++ b/runtime/observatory/tests/service/parameters_in_scope_at_entry_test.dart
@@ -8,6 +8,11 @@ import 'test_helper.dart';
import 'dart:developer';
import 'package:unittest/unittest.dart';
+import 'service_test_common.dart';
+
+const int LINE_A = 29;
+const int LINE_B = 33;
+
foo(param) {
return param;
}
@@ -21,16 +26,16 @@ fooClosure() {
testMain() {
debugger();
- foo("in-scope"); // Line 24
+ foo("in-scope"); // Line A.
var f = fooClosure();
debugger();
- f("in-scope"); // Line 28
+ f("in-scope"); // Line B.
}
var tests = [
hasStoppedAtBreakpoint,
- stoppedAtLine(24),
+ stoppedAtLine(LINE_A),
(isolate) => isolate.stepInto(),
hasStoppedAtBreakpoint,
(isolate) async {
@@ -47,7 +52,7 @@ var tests = [
resumeIsolate,
hasStoppedAtBreakpoint,
- stoppedAtLine(28),
+ stoppedAtLine(LINE_B),
(isolate) => isolate.stepInto(),
hasStoppedAtBreakpoint,
(isolate) async {

Powered by Google App Engine
This is Rietveld 408576698