Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 1726763002: Use ARM fixes for SDF encoding. (Closed)

Created:
4 years, 10 months ago by jvanverth1
Modified:
4 years, 10 months ago
CC:
reviews_skia.org, developer_arm.com
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Update some comments #

Total comments: 2

Patch Set 3 : Fix another comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -13 lines) Patch
M src/core/SkDistanceFieldGen.h View 1 2 2 chunks +5 lines, -4 lines 0 comments Download
M src/core/SkDistanceFieldGen.cpp View 1 2 chunks +15 lines, -9 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
jvanverth1
Joel, I pulled out just the encoding change into this patch so we can at ...
4 years, 10 months ago (2016-02-23 18:11:17 UTC) #3
Joel.Liang
https://codereview.chromium.org/1726763002/diff/20001/src/core/SkDistanceFieldGen.h File src/core/SkDistanceFieldGen.h (right): https://codereview.chromium.org/1726763002/diff/20001/src/core/SkDistanceFieldGen.h#newcode23 src/core/SkDistanceFieldGen.h:23: // and the range is [-4, 4 - 1/255). ...
4 years, 10 months ago (2016-02-24 04:10:24 UTC) #4
jvanverth1
https://codereview.chromium.org/1726763002/diff/20001/src/core/SkDistanceFieldGen.h File src/core/SkDistanceFieldGen.h (right): https://codereview.chromium.org/1726763002/diff/20001/src/core/SkDistanceFieldGen.h#newcode23 src/core/SkDistanceFieldGen.h:23: // and the range is [-4, 4 - 1/255). ...
4 years, 10 months ago (2016-02-24 14:57:13 UTC) #5
Joel.Liang
lgtm
4 years, 10 months ago (2016-02-24 15:24:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1726763002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1726763002/40001
4 years, 10 months ago (2016-02-24 16:16:39 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-24 16:33:13 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/970fd1fbea16da013d5b103182d78499ed85f95f

Powered by Google App Engine
This is Rietveld 408576698