Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 1726723002: [NaCL SDK] nacl_io: Re-enable UnixSocketMultithreadedTest.SendRecv (Closed)

Created:
4 years, 10 months ago by avallee
Modified:
4 years, 10 months ago
Reviewers:
Sam Clegg
CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NaCL SDK] nacl_io: Re-enable UnixSocketMultithreadedTest.SendRecv Spamminess and flakiness should be fixed by the previous CL. BUG=588784 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_nacl_sdk;tryserver.chromium.mac:mac_nacl_sdk;tryserver.chromium.win:win_nacl_sdk Committed: https://crrev.com/b91db5809d1122ee4356f395dbf7b1808d1a1f21 Cr-Commit-Position: refs/heads/master@{#377406}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M native_client_sdk/src/tests/nacl_io_test/socket_test.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
avallee
4 years, 10 months ago (2016-02-24 16:38:10 UTC) #2
avallee
4 years, 10 months ago (2016-02-24 16:38:12 UTC) #3
Sam Clegg
lgtm
4 years, 10 months ago (2016-02-24 18:17:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1726723002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1726723002/1
4 years, 10 months ago (2016-02-24 18:44:49 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-24 22:16:44 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-24 22:19:49 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b91db5809d1122ee4356f395dbf7b1808d1a1f21
Cr-Commit-Position: refs/heads/master@{#377406}

Powered by Google App Engine
This is Rietveld 408576698