Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 1726703002: Add increment install native libraries first in lookup paths (Closed)

Created:
4 years, 10 months ago by agrieve
Modified:
4 years, 10 months ago
Reviewers:
Xi Han
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add increment install native libraries first in lookup paths This fixes a subtle bug where the wrong libchromium_android_linker.so is used when it already exists in the system library path. BUG=587584 Committed: https://crrev.com/86af989585dd6aac45d3087456ef7cafb37afa86 Cr-Commit-Position: refs/heads/master@{#377074}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M build/android/incremental_install/java/org/chromium/incrementalinstall/ClassLoaderPatcher.java View 2 chunks +3 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (8 generated)
agrieve
On 2016/02/23 16:33:36, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:hanxi@chromium.org 🔌
4 years, 10 months ago (2016-02-23 16:33:49 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1726703002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1726703002/1
4 years, 10 months ago (2016-02-23 16:45:02 UTC) #6
Xi Han
lgtm. As long as you only need to put the Chrome's native library directories before ...
4 years, 10 months ago (2016-02-23 17:54:01 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-23 18:45:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1726703002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1726703002/1
4 years, 10 months ago (2016-02-23 19:50:34 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-23 20:13:27 UTC) #13
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/86af989585dd6aac45d3087456ef7cafb37afa86 Cr-Commit-Position: refs/heads/master@{#377074}
4 years, 10 months ago (2016-02-23 20:15:08 UTC) #15
agrieve
4 years, 10 months ago (2016-02-24 01:03:57 UTC) #16
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1731593003/ by agrieve@chromium.org.

The reason for reverting is: Breaks incremental install for M devices..

Powered by Google App Engine
This is Rietveld 408576698