Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 1726653002: Limit number of browsers opened by test script to 15. (Closed)

Created:
4 years, 10 months ago by Bill Hesse
Modified:
4 years, 10 months ago
Reviewers:
ricow1
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Limit number of browsers opened by test script to 15. BUG= R=ricow@google.com Committed: https://github.com/dart-lang/sdk/commit/1f76ab9410598fca0f7c7c8c9d650cf006950fb3

Patch Set 1 #

Patch Set 2 : Set limit in a better place. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M tools/testing/dart/test_configurations.dart View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Bill Hesse
4 years, 10 months ago (2016-02-23 13:39:27 UTC) #2
ricow1
as discussed offline yesterday, I don't think this belongs in here, but in the configuration ...
4 years, 10 months ago (2016-02-24 07:53:37 UTC) #3
Bill Hesse
Please take a look.
4 years, 10 months ago (2016-02-24 12:53:57 UTC) #4
ricow1
lgtm
4 years, 10 months ago (2016-02-24 12:57:07 UTC) #5
Bill Hesse
4 years, 10 months ago (2016-02-24 12:59:36 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
1f76ab9410598fca0f7c7c8c9d650cf006950fb3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698