Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Issue 1726613003: only include xdg_util_unittest.cc on desktop linux (Closed)

Created:
4 years, 10 months ago by Mostyn Bramley-Moore
Modified:
4 years, 9 months ago
Reviewers:
brettw
CC:
chromium-reviews, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

only include xdg_util_unittest.cc on desktop linux Committed: https://crrev.com/51f5107113dc773b50ce7ee8be8c2c4b0bbf23b0 Cr-Commit-Position: refs/heads/master@{#377373}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M base/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
Mostyn Bramley-Moore
@brettw: here's another small gn build fixup.
4 years, 10 months ago (2016-02-23 15:35:49 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1726613003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1726613003/1
4 years, 10 months ago (2016-02-23 15:36:34 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-23 16:08:51 UTC) #6
brettw
lgtm
4 years, 9 months ago (2016-02-24 19:00:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1726613003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1726613003/1
4 years, 9 months ago (2016-02-24 19:57:08 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-02-24 20:43:47 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-02-24 20:44:39 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/51f5107113dc773b50ce7ee8be8c2c4b0bbf23b0
Cr-Commit-Position: refs/heads/master@{#377373}

Powered by Google App Engine
This is Rietveld 408576698