Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Issue 172643002: Stub to prevent VS2013 from creating unwanted .gitattributes. (Closed)

Created:
6 years, 10 months ago by Michael Moss
Modified:
6 years, 10 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Stub to prevent VS2013 from creating unwanted .gitattributes. BUG=342064 R=darin@chromium.org, scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252039

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
A .gitattributes View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Michael Moss
6 years, 10 months ago (2014-02-19 17:56:22 UTC) #1
scottmg
Oops, thanks I forgot to do that. LGTM
6 years, 10 months ago (2014-02-19 17:57:07 UTC) #2
Michael Moss
+darin for OWNERS
6 years, 10 months ago (2014-02-19 17:57:07 UTC) #3
scottmg
Maybe add something about VS2013 and/or the crbug in the comment.
6 years, 10 months ago (2014-02-19 17:57:34 UTC) #4
Michael Moss
On 2014/02/19 17:57:34, scottmg wrote: > Maybe add something about VS2013 and/or the crbug in ...
6 years, 10 months ago (2014-02-19 18:03:04 UTC) #5
darin (slow to review)
LGTM
6 years, 10 months ago (2014-02-19 18:45:24 UTC) #6
Michael Moss
The CQ bit was checked by mmoss@chromium.org
6 years, 10 months ago (2014-02-19 18:53:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mmoss@chromium.org/172643002/70001
6 years, 10 months ago (2014-02-19 19:04:57 UTC) #8
Michael Moss
6 years, 10 months ago (2014-02-19 19:09:40 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 manually as r252039 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698