components/safe_browsing_db/database_manager.h - Issue 1726403006: Switch Safe Browsing's metadata from string to struct.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/safe_browsing_db/database_manager.h

Issue 1726403006: Switch Safe Browsing's metadata from string to struct. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix ParseJson in test Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/safe_browsing_db/database_manager.h

diff --git a/components/safe_browsing_db/database_manager.h b/components/safe_browsing_db/database_manager.h

index 660a6eefb19d2fbbd27ac9defa9ae8e361ce675f..f5ba2dbe24718f88eba2a18a96c94f6d6a9f93e4 100644

--- a/components/safe_browsing_db/database_manager.h

+++ b/components/safe_browsing_db/database_manager.h

@@ -43,7 +43,7 @@ class SafeBrowsingDatabaseManager

// Called when the result of checking a browse URL is known.

virtual void OnCheckBrowseUrlResult(const GURL& url,

SBThreatType threat_type,

- const std::string& metadata) {}

+ const ThreatMetadata& metadata) {}

// Called when the result of checking a download URL is known.

virtual void OnCheckDownloadUrlResult(const std::vector<GURL>& url_chain,

« no previous file with comments | « components/components_tests.gyp ('k') | components/safe_browsing_db/remote_database_manager.cc » ('j') | no next file with comments »