Switch Safe Browsing's metadata from string to struct.

components/safe_browsing_db/v4_get_hash_protocol_manager.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/safe_browsing_db/v4_get_hash_protocol_manager.h"
 
 #include <utility>
 
 #include "base/base64.h"
 #include "base/macros.h"
@@ skipping 193 matching lines @@
       // Seconds resolution is good enough so we ignore the nanos field.
       result.cache_duration =
           base::TimeDelta::FromSeconds(match.cache_duration().seconds());
     }
 
     // Different threat types will handle the metadata differently.
     if (match.threat_type() == API_ABUSE) {
       if (match.has_platform_type() &&
           match.platform_type() == CHROME_PLATFORM) {
         if (match.has_threat_entry_metadata()) {
-          // For API Abuse, store a csv of the returned permissions.
+          // For API Abuse, store a list of the returned permissions.
           for (const ThreatEntryMetadata::MetadataEntry& m :
                match.threat_entry_metadata().entries()) {
             if (m.key() == "permission") {
-              result.metadata += m.value() + ",";
+              result.metadata.api_permissions.push_back(m.value());
             }
           }
         } else {
           RecordParseGetHashResult(NO_METADATA_ERROR);
           return false;
         }
       } else {
         RecordParseGetHashResult(UNEXPECTED_PLATFORM_TYPE_ERROR);
         return false;
       }
@@ skipping 109 matching lines @@
   next_gethash_time_ = now + next;
 }
 
 GURL V4GetHashProtocolManager::GetHashUrl(const std::string& req_base64) const {
   return V4ProtocolManagerUtil::GetRequestUrl(req_base64, "encodedFullHashes",
                                               config_);
 }
 
 
 }  // namespace safe_browsing