Issue 17264006: Fix VariationsRequestScheduler::ScheduleFetchShortly() to actually work.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17264006: Fix VariationsRequestScheduler::ScheduleFetchShortly() to actually work. (Closed)

Created:
7 years, 6 months ago by Alexei Svitkine (slow)

Modified:
7 years, 6 months ago

Reviewers:
jwd

CC:
chromium-reviews, Ilya Sherman, jar (doing other things), asvitkine+watch_chromium.org, SteveT

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Fix VariationsRequestScheduler::ScheduleFetchShortly() to actually work. It was calling Reset() that stopped the one_shot_timer_ it had just started. BUG=247820 R=jwd@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207068

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	chrome/browser/metrics/variations/variations_request_scheduler.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/17264006/1

7 years, 6 months ago (2013-06-18 18:18:52 UTC) #4

Alexei Svitkine (slow)

7 years, 6 months ago (2013-06-18 19:57:54 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r207068 (presubmit successful).