xfa/src/fxbarcode/pdf417/BC_PDF417.cpp - Issue 1726373002: Remove foo != NULL checks in xfa/src/fxbarcode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/src/fxbarcode/pdf417/BC_PDF417.cpp

Issue 1726373002: Remove foo != NULL checks in xfa/src/fxbarcode. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: rebase Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/src/fxbarcode/pdf417/BC_PDF417.cpp

diff --git a/xfa/src/fxbarcode/pdf417/BC_PDF417.cpp b/xfa/src/fxbarcode/pdf417/BC_PDF417.cpp

index c8b7c4cffa2b587861a6c4710deb8019f281ad01..c06f8112da6abbd8e6f225947b917bed20484a78 100644

--- a/xfa/src/fxbarcode/pdf417/BC_PDF417.cpp

+++ b/xfa/src/fxbarcode/pdf417/BC_PDF417.cpp

@@ -553,7 +553,7 @@ CFX_Int32Array* CBC_PDF417::determineDimensions(

}

FX_FLOAT newRatio =

((17 * cols + 69) * DEFAULT_MODULE_WIDTH) / (rows * HEIGHT);

- if (dimension != NULL &&

+ if (dimension &&

fabsf(newRatio - PREFERRED_RATIO) > fabsf(ratio - PREFERRED_RATIO)) {

continue;

}