xfa/src/fxbarcode/pdf417/BC_PDF417DetectionResultRowIndicatorColumn.cpp - Issue 1726373002: Remove foo != NULL checks in xfa/src/fxbarcode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/src/fxbarcode/pdf417/BC_PDF417DetectionResultRowIndicatorColumn.cpp

Issue 1726373002: Remove foo != NULL checks in xfa/src/fxbarcode. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« xfa/src/fxbarcode/oned/BC_OnedEAN8Reader.cpp ('K') | « xfa/src/fxbarcode/pdf417/BC_PDF417DetectionResultColumn.cpp ('k') | xfa/src/fxbarcode/pdf417/BC_PDF417Detector.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: xfa/src/fxbarcode/pdf417/BC_PDF417DetectionResultRowIndicatorColumn.cpp

diff --git a/xfa/src/fxbarcode/pdf417/BC_PDF417DetectionResultRowIndicatorColumn.cpp b/xfa/src/fxbarcode/pdf417/BC_PDF417DetectionResultRowIndicatorColumn.cpp

index 14a87d60a22a8be7dbdda4dff67d0cd82aa7bb06..f90e9eb62f5ffab6c6b6b2a4e862e95b68ea25a9 100644

--- a/xfa/src/fxbarcode/pdf417/BC_PDF417DetectionResultRowIndicatorColumn.cpp

+++ b/xfa/src/fxbarcode/pdf417/BC_PDF417DetectionResultRowIndicatorColumn.cpp

@@ -40,7 +40,7 @@ CBC_DetectionResultRowIndicatorColumn::

void CBC_DetectionResultRowIndicatorColumn::setRowNumbers() {

for (int32_t i = 0; i < m_codewords->GetSize(); i++) {

CBC_Codeword* codeword = (CBC_Codeword*)m_codewords->GetAt(i);

- if (codeword != NULL) {

+ if (codeword) {

codeword->setRowNumberAsRowIndicatorColumn();

}

@@ -117,7 +117,7 @@ CFX_Int32Array* CBC_DetectionResultRowIndicatorColumn::getRowHeights(

result->SetSize(barcodeMetadata->getRowCount());

for (int32_t i = 0; i < getCodewords()->GetSize(); i++) {

CBC_Codeword* codeword = (CBC_Codeword*)getCodewords()->GetAt(i);

- if (codeword != NULL) {

+ if (codeword) {

result->SetAt(codeword->getRowNumber(),

result->GetAt(codeword->getRowNumber()) + 1);

}