xfa/src/fxbarcode/pdf417/BC_PDF417BoundingBox.cpp - Issue 1726373002: Remove foo != NULL checks in xfa/src/fxbarcode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/src/fxbarcode/pdf417/BC_PDF417BoundingBox.cpp

Issue 1726373002: Remove foo != NULL checks in xfa/src/fxbarcode. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/src/fxbarcode/pdf417/BC_PDF417BoundingBox.cpp

diff --git a/xfa/src/fxbarcode/pdf417/BC_PDF417BoundingBox.cpp b/xfa/src/fxbarcode/pdf417/BC_PDF417BoundingBox.cpp

index c14e0de1333765f0154fefc9c4d4cc409643ca7c..f2f7b06a59849e8e9530d700af5986f385f98ccc 100644

--- a/xfa/src/fxbarcode/pdf417/BC_PDF417BoundingBox.cpp

+++ b/xfa/src/fxbarcode/pdf417/BC_PDF417BoundingBox.cpp

@@ -32,8 +32,7 @@ CBC_BoundingBox::CBC_BoundingBox(CBC_CommonBitMatrix* image,

int32_t& e) {

if ((topLeft == NULL && topRight == NULL) ||

(bottomLeft == NULL && bottomRight == NULL) ||

- (topLeft != NULL && bottomLeft == NULL) ||

- (topRight != NULL && bottomRight == NULL)) {

+ (topLeft && bottomLeft == NULL) || (topRight && bottomRight == NULL)) {

e = BCExceptionNotFoundInstance;

}

init(image, topLeft, bottomLeft, topRight, bottomRight);