xfa/src/fxbarcode/oned/BC_OneDimReader.cpp - Issue 1726373002: Remove foo != NULL checks in xfa/src/fxbarcode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/src/fxbarcode/oned/BC_OneDimReader.cpp

Issue 1726373002: Remove foo != NULL checks in xfa/src/fxbarcode. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/src/fxbarcode/oned/BC_OneDimReader.cpp

diff --git a/xfa/src/fxbarcode/oned/BC_OneDimReader.cpp b/xfa/src/fxbarcode/oned/BC_OneDimReader.cpp

index 8de79c12c42c42d9746d54f8ad9720479f034024..1af2240eb8dd676c1c2f9f80039f41df715d9198 100644

--- a/xfa/src/fxbarcode/oned/BC_OneDimReader.cpp

+++ b/xfa/src/fxbarcode/oned/BC_OneDimReader.cpp

@@ -50,10 +50,7 @@ CFX_Int32Array* CBC_OneDimReader::FindStartGuardPattern(CBC_CommonBitArray* row,

startEndPattern[2] = START_END_PATTERN[2];

int32_t nextStart = 0;

while (!foundStart) {

- if (startRange != NULL) {

- delete startRange;

- startRange = NULL;

- }

+ delete startRange;

startRange = FindGuardPattern(row, nextStart, FALSE, &startEndPattern, e);

BC_EXCEPTION_CHECK_ReturnValue(e, NULL);

int32_t start = (*startRange)[0];