Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Side by Side Diff: xfa/src/fxbarcode/qrcode/BC_QRDataBlock.cpp

Issue 1726373002: Remove foo != NULL checks in xfa/src/fxbarcode. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 // Original code is licensed as follows: 6 // Original code is licensed as follows:
7 /* 7 /*
8 * Copyright 2007 ZXing authors 8 * Copyright 2007 ZXing authors
9 * 9 *
10 * Licensed under the Apache License, Version 2.0 (the "License"); 10 * Licensed under the Apache License, Version 2.0 (the "License");
(...skipping 11 matching lines...) Expand all
22 22
23 #include "xfa/src/fxbarcode/barcode.h" 23 #include "xfa/src/fxbarcode/barcode.h"
24 #include "xfa/src/fxbarcode/qrcode/BC_QRCoderECB.h" 24 #include "xfa/src/fxbarcode/qrcode/BC_QRCoderECB.h"
25 #include "xfa/src/fxbarcode/qrcode/BC_QRCoderECBlocks.h" 25 #include "xfa/src/fxbarcode/qrcode/BC_QRCoderECBlocks.h"
26 #include "xfa/src/fxbarcode/qrcode/BC_QRCoderVersion.h" 26 #include "xfa/src/fxbarcode/qrcode/BC_QRCoderVersion.h"
27 #include "xfa/src/fxbarcode/qrcode/BC_QRDataBlock.h" 27 #include "xfa/src/fxbarcode/qrcode/BC_QRDataBlock.h"
28 CBC_QRDataBlock::CBC_QRDataBlock(int32_t numDataCodewords, 28 CBC_QRDataBlock::CBC_QRDataBlock(int32_t numDataCodewords,
29 CFX_ByteArray* codewords) 29 CFX_ByteArray* codewords)
30 : m_numDataCodewords(numDataCodewords), m_codewords(codewords) {} 30 : m_numDataCodewords(numDataCodewords), m_codewords(codewords) {}
31 CBC_QRDataBlock::~CBC_QRDataBlock() { 31 CBC_QRDataBlock::~CBC_QRDataBlock() {
32 if (m_codewords != NULL) { 32 delete m_codewords;
33 delete m_codewords;
34 m_codewords = NULL;
35 }
36 } 33 }
37 int32_t CBC_QRDataBlock::GetNumDataCodewords() { 34 int32_t CBC_QRDataBlock::GetNumDataCodewords() {
38 return m_numDataCodewords; 35 return m_numDataCodewords;
39 } 36 }
40 CFX_ByteArray* CBC_QRDataBlock::GetCodewords() { 37 CFX_ByteArray* CBC_QRDataBlock::GetCodewords() {
41 return m_codewords; 38 return m_codewords;
42 } 39 }
43 CFX_PtrArray* CBC_QRDataBlock::GetDataBlocks( 40 CFX_PtrArray* CBC_QRDataBlock::GetDataBlocks(
44 CFX_ByteArray* rawCodewords, 41 CFX_ByteArray* rawCodewords,
45 CBC_QRCoderVersion* version, 42 CBC_QRCoderVersion* version,
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
102 int32_t max = ((CBC_QRDataBlock*)(*result)[0])->m_codewords->GetSize(); 99 int32_t max = ((CBC_QRDataBlock*)(*result)[0])->m_codewords->GetSize();
103 for (i = shorterBlocksNumDataCodewords; i < max; i++) { 100 for (i = shorterBlocksNumDataCodewords; i < max; i++) {
104 for (int32_t y = 0; y < numResultBlocks; y++) { 101 for (int32_t y = 0; y < numResultBlocks; y++) {
105 int32_t iOffset = y < longerBlocksStartAt ? i : i + 1; 102 int32_t iOffset = y < longerBlocksStartAt ? i : i + 1;
106 (*(((CBC_QRDataBlock*)(*result)[y])->m_codewords))[iOffset] = 103 (*(((CBC_QRDataBlock*)(*result)[y])->m_codewords))[iOffset] =
107 (*rawCodewords)[rawCodewordsOffset++]; 104 (*rawCodewords)[rawCodewordsOffset++];
108 } 105 }
109 } 106 }
110 return result.release(); 107 return result.release();
111 } 108 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698