Remove foo != NULL checks in xfa/src/fxbarcode.

xfa/src/fxbarcode/qrcode/BC_QRBitMatrixParser.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 // Original code is licensed as follows:
 /*
  * Copyright 2007 ZXing authors
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
@@ skipping 22 matching lines @@
   m_tempBitMatrix = bitMatrix;
   if (m_dimension < 21 || (m_dimension & 0x03) != 1) {
     e = BCExceptionRead;
     BC_EXCEPTION_CHECK_ReturnVoid(e);
   }
   m_bitMatrix = m_tempBitMatrix;
   m_parsedFormatInfo = NULL;
   m_version = NULL;
 }
 CBC_QRBitMatrixParser::~CBC_QRBitMatrixParser() {
-  if (m_parsedFormatInfo != NULL) {
-    delete m_parsedFormatInfo;
-    m_parsedFormatInfo = NULL;
-  }
-  m_version = NULL;
+  delete m_parsedFormatInfo;
 }
 CBC_QRCoderFormatInformation* CBC_QRBitMatrixParser::ReadFormatInformation(
     int32_t& e) {
-  if (m_parsedFormatInfo != NULL) {
+  if (m_parsedFormatInfo) {
     return m_parsedFormatInfo;
   }
   int32_t formatInfoBits = 0;
   int32_t j;
   for (j = 0; j < 6; j++) {
     formatInfoBits = CopyBit(8, j, formatInfoBits);
   }
   formatInfoBits = CopyBit(8, 7, formatInfoBits);
   formatInfoBits = CopyBit(8, 8, formatInfoBits);
   formatInfoBits = CopyBit(7, 8, formatInfoBits);
   for (int32_t i = 5; i >= 0; i--) {
     formatInfoBits = CopyBit(i, 8, formatInfoBits);
   }
   m_parsedFormatInfo =
       CBC_QRCoderFormatInformation::DecodeFormatInformation(formatInfoBits);
-  if (m_parsedFormatInfo != NULL) {
+  if (m_parsedFormatInfo) {
     return m_parsedFormatInfo;
   }
   int32_t dimension = m_bitMatrix->GetDimension(e);
   BC_EXCEPTION_CHECK_ReturnValue(e, NULL);
   formatInfoBits = 0;
   int32_t iMin = dimension - 8;
   for (j = dimension - 1; j >= iMin; j--) {
     formatInfoBits = CopyBit(j, 8, formatInfoBits);
   }
   for (int32_t k = dimension - 7; k < dimension; k++) {
     formatInfoBits = CopyBit(8, k, formatInfoBits);
   }
   m_parsedFormatInfo =
       CBC_QRCoderFormatInformation::DecodeFormatInformation(formatInfoBits);
-  if (m_parsedFormatInfo != NULL) {
+  if (m_parsedFormatInfo) {
     return m_parsedFormatInfo;
   }
   e = BCExceptionRead;
   BC_EXCEPTION_CHECK_ReturnValue(e, NULL);
   return NULL;
 }
 CBC_QRCoderVersion* CBC_QRBitMatrixParser::ReadVersion(int32_t& e) {
-  if (m_version != NULL) {
+  if (m_version) {
     return m_version;
   }
   int32_t dimension = m_bitMatrix->GetDimension(e);
   BC_EXCEPTION_CHECK_ReturnValue(e, NULL);
   int32_t provisionVersion = (dimension - 17) >> 2;
   if (provisionVersion <= 6) {
     CBC_QRCoderVersion* qrv =
         CBC_QRCoderVersion::GetVersionForNumber(provisionVersion, e);
     BC_EXCEPTION_CHECK_ReturnValue(e, NULL);
     return qrv;
   }
   int32_t versionBits = 0;
   for (int32_t i = 5; i >= 0; i--) {
     int32_t jMin = dimension - 11;
     for (int32_t j = dimension - 9; j >= jMin; j--) {
       versionBits = CopyBit(i, j, versionBits);
     }
   }
   m_version = CBC_QRCoderVersion::DecodeVersionInformation(versionBits, e);
   BC_EXCEPTION_CHECK_ReturnValue(e, NULL);
-  if (m_version != NULL && m_version->GetDimensionForVersion() == dimension) {
+  if (m_version && m_version->GetDimensionForVersion() == dimension) {
     return m_version;
   }
   versionBits = 0;
   for (int32_t j = 5; j >= 0; j--) {
     int32_t iMin = dimension - 11;
     for (int32_t i = dimension - 9; i >= iMin; i--) {
       versionBits = CopyBit(i, j, versionBits);
     }
   }
   m_version = CBC_QRCoderVersion::DecodeVersionInformation(versionBits, e);
   BC_EXCEPTION_CHECK_ReturnValue(e, NULL);
-  if (m_version != NULL && m_version->GetDimensionForVersion() == dimension) {
+  if (m_version && m_version->GetDimensionForVersion() == dimension) {
     return m_version;
   }
   e = BCExceptionRead;
   BC_EXCEPTION_CHECK_ReturnValue(e, NULL);
   return NULL;
 }
 int32_t CBC_QRBitMatrixParser::CopyBit(int32_t i,
                                        int32_t j,
                                        int32_t versionBits) {
   return m_bitMatrix->Get(j, i) ? (versionBits << 1) | 0x1 : versionBits << 1;
@@ skipping 41 matching lines @@
       }
     }
     readingUp ^= TRUE;
   }
   if (resultOffset != version->GetTotalCodeWords()) {
     e = BCExceptionRead;
     BC_EXCEPTION_CHECK_ReturnValue(e, NULL);
   }
   return result.release();
 }