Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Side by Side Diff: xfa/src/fxbarcode/oned/BC_OnedCode128Reader.cpp

Issue 1726373002: Remove foo != NULL checks in xfa/src/fxbarcode. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 // Original code is licensed as follows: 6 // Original code is licensed as follows:
7 /* 7 /*
8 * Copyright 2008 ZXing authors 8 * Copyright 2008 ZXing authors
9 * 9 *
10 * Licensed under the Apache License, Version 2.0 (the "License"); 10 * Licensed under the Apache License, Version 2.0 (the "License");
(...skipping 171 matching lines...) Expand 10 before | Expand all | Expand 10 after
182 case 103: 182 case 103:
183 codeSet = CODE_CODE_A; 183 codeSet = CODE_CODE_A;
184 break; 184 break;
185 case 104: 185 case 104:
186 codeSet = CODE_CODE_B; 186 codeSet = CODE_CODE_B;
187 break; 187 break;
188 case 105: 188 case 105:
189 codeSet = CODE_CODE_C; 189 codeSet = CODE_CODE_C;
190 break; 190 break;
191 default: 191 default:
192 if (startPatternInfo != NULL) { 192 if (startPatternInfo) {
193 startPatternInfo->RemoveAll(); 193 startPatternInfo->RemoveAll();
194 delete startPatternInfo; 194 delete startPatternInfo;
195 startPatternInfo = NULL; 195 startPatternInfo = NULL;
196 } 196 }
197 e = BCExceptionFormatException; 197 e = BCExceptionFormatException;
198 return ""; 198 return "";
199 } 199 }
200 FX_BOOL done = FALSE; 200 FX_BOOL done = FALSE;
201 FX_BOOL isNextShifted = FALSE; 201 FX_BOOL isNextShifted = FALSE;
202 CFX_ByteString result; 202 CFX_ByteString result;
203 int32_t lastStart = (*startPatternInfo)[0]; 203 int32_t lastStart = (*startPatternInfo)[0];
204 int32_t nextStart = (*startPatternInfo)[1]; 204 int32_t nextStart = (*startPatternInfo)[1];
205 if (startPatternInfo != NULL) { 205 if (startPatternInfo) {
206 startPatternInfo->RemoveAll(); 206 startPatternInfo->RemoveAll();
207 delete startPatternInfo; 207 delete startPatternInfo;
208 startPatternInfo = NULL; 208 startPatternInfo = NULL;
209 } 209 }
210 CFX_Int32Array counters; 210 CFX_Int32Array counters;
211 counters.SetSize(6); 211 counters.SetSize(6);
212 int32_t lastCode = 0; 212 int32_t lastCode = 0;
213 int32_t code = 0; 213 int32_t code = 0;
214 int32_t checksumTotal = startCode; 214 int32_t checksumTotal = startCode;
215 int32_t multiplier = 0; 215 int32_t multiplier = 0;
(...skipping 143 matching lines...) Expand 10 before | Expand all | Expand 10 after
359 } else { 359 } else {
360 result = result.Mid(0, result.GetLength() - 1); 360 result = result.Mid(0, result.GetLength() - 1);
361 } 361 }
362 } 362 }
363 if (result.GetLength() == 0) { 363 if (result.GetLength() == 0) {
364 e = BCExceptionFormatException; 364 e = BCExceptionFormatException;
365 return ""; 365 return "";
366 } 366 }
367 return result; 367 return result;
368 } 368 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698