Remove foo != NULL checks in xfa/src/fxbarcode.

xfa/src/fxbarcode/datamatrix/BC_DataMatrixDetector.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 // Original code is licensed as follows:
 /*
  * Copyright 2008 ZXing authors
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
@@ skipping 21 matching lines @@
 #include "xfa/src/fxbarcode/qrcode/BC_QRGridSampler.h"
 const int32_t CBC_DataMatrixDetector::INTEGERS[5] = {0, 1, 2, 3, 4};
 CBC_DataMatrixDetector::CBC_DataMatrixDetector(CBC_CommonBitMatrix* image)
     : m_image(image), m_rectangleDetector(NULL) {}
 void CBC_DataMatrixDetector::Init(int32_t& e) {
   m_rectangleDetector = new CBC_WhiteRectangleDetector(m_image);
   m_rectangleDetector->Init(e);
   BC_EXCEPTION_CHECK_ReturnVoid(e);
 }
 CBC_DataMatrixDetector::~CBC_DataMatrixDetector() {
-  if (m_rectangleDetector != NULL) {
-    delete m_rectangleDetector;
-  }
-  m_rectangleDetector = NULL;
+  delete m_rectangleDetector;
 }
 inline FX_BOOL ResultPointsAndTransitionsComparator(void* a, void* b) {
   return ((CBC_ResultPointsAndTransitions*)b)->GetTransitions() >
          ((CBC_ResultPointsAndTransitions*)a)->GetTransitions();
 }
 CBC_QRDetectorResult* CBC_DataMatrixDetector::Detect(int32_t& e) {
   CFX_PtrArray* cornerPoints = m_rectangleDetector->Detect(e);
   BC_EXCEPTION_CHECK_ReturnValue(e, NULL);
   CBC_ResultPoint* pointA = (CBC_ResultPoint*)(*cornerPoints)[0];
   CBC_ResultPoint* pointB = (CBC_ResultPoint*)(*cornerPoints)[1];
@@ skipping 18 matching lines @@
   Increment(pointCount, lSideOne->GetTo());
   Increment(pointCount, lSideTwo->GetFrom());
   Increment(pointCount, lSideTwo->GetTo());
   delete ((CBC_ResultPointsAndTransitions*)transitions[1]);
   delete ((CBC_ResultPointsAndTransitions*)transitions[0]);
   transitions.RemoveAll();
   CBC_ResultPoint* maybeTopLeft = NULL;
   CBC_ResultPoint* bottomLeft = NULL;
   CBC_ResultPoint* maybeBottomRight = NULL;
   FX_POSITION itBegin = pointCount.GetStartPosition();
-  while (itBegin != NULL) {
+  while (itBegin) {
     CBC_ResultPoint* key = 0;
     int32_t value = 0;
     pointCount.GetNextAssoc(itBegin, key, value);
     if (value == 2) {
       bottomLeft = key;
     } else {
       if (maybeBottomRight == NULL) {
         maybeBottomRight = key;
       } else {
         maybeTopLeft = key;
@@ skipping 302 matching lines @@
       (bottomLeft->GetX() - topLeft->GetX()) *
           (topRight->GetY() - topLeft->GetY())) {
     CBC_ResultPoint* temp = topRight;
     topRight = bottomLeft;
     bottomLeft = temp;
   }
   (*patterns)[0] = bottomLeft;
   (*patterns)[1] = topLeft;
   (*patterns)[2] = topRight;
 }