Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(627)

Issue 172633005: NaCl: Move definition of "struct nacl_irt_ppapihook" to the Chromium repo (Closed)

Created:
6 years, 10 months ago by Mark Seaborn
Modified:
6 years, 10 months ago
Reviewers:
teravest
CC:
chromium-reviews
Visibility:
Public.

Description

NaCl: Move definition of "struct nacl_irt_ppapihook" to the Chromium repo This will allow the definition to be removed from NaCl's irt.h. BUG=https://code.google.com/p/nativeclient/issues/detail?id=3787 TEST=build R=teravest@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252185

Patch Set 1 #

Total comments: 2

Patch Set 2 : Review #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -7 lines) Patch
M ppapi/nacl_irt/irt_ppapi.h View 1 2 chunks +16 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Mark Seaborn
6 years, 10 months ago (2014-02-19 20:32:11 UTC) #1
teravest
lgtm https://codereview.chromium.org/172633005/diff/1/ppapi/nacl_irt/irt_ppapi.h File ppapi/nacl_irt/irt_ppapi.h (right): https://codereview.chromium.org/172633005/diff/1/ppapi/nacl_irt/irt_ppapi.h#newcode8 ppapi/nacl_irt/irt_ppapi.h:8: #define PPAPI_NACL_IRT_IRT_PPAPI_H_ 1 Is there a toolchain reason ...
6 years, 10 months ago (2014-02-19 20:33:59 UTC) #2
Mark Seaborn
https://codereview.chromium.org/172633005/diff/1/ppapi/nacl_irt/irt_ppapi.h File ppapi/nacl_irt/irt_ppapi.h (right): https://codereview.chromium.org/172633005/diff/1/ppapi/nacl_irt/irt_ppapi.h#newcode8 ppapi/nacl_irt/irt_ppapi.h:8: #define PPAPI_NACL_IRT_IRT_PPAPI_H_ 1 On 2014/02/19 20:33:59, teravest wrote: > ...
6 years, 10 months ago (2014-02-19 23:14:01 UTC) #3
Mark Seaborn
The CQ bit was checked by mseaborn@chromium.org
6 years, 10 months ago (2014-02-19 23:15:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mseaborn@chromium.org/172633005/100001
6 years, 10 months ago (2014-02-19 23:20:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mseaborn@chromium.org/172633005/100001
6 years, 10 months ago (2014-02-20 01:13:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mseaborn@chromium.org/172633005/100001
6 years, 10 months ago (2014-02-20 05:00:05 UTC) #7
Mark Seaborn
6 years, 10 months ago (2014-02-20 05:12:45 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 manually as r252185 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698