Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 172633004: Refactor Windows MessageBox fallback code. (Closed)

Created:
6 years, 10 months ago by msw
Modified:
6 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, jam
Visibility:
Public.

Description

Refactor Windows MessageBox fallback code. Inline the Windows-specific NativeShowMessageBox. Pass the parent HWND argument to the underlying call. Use MB_ICONQUESTION for MESSAGE_BOX_TYPE_QUESTION. BUG=NONE TEST=No Win MessageBox regressions; better icon for any fallback question MessageBox. R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252197

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -64 lines) Patch
M chrome/browser/hang_monitor/hung_plugin_action.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/ui/simple_message_box.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/views/simple_message_box_views.cc View 2 chunks +27 lines, -6 lines 0 comments Download
D chrome/browser/ui/views/simple_message_box_win.h View 1 chunk +0 lines, -19 lines 0 comments Download
D chrome/browser/ui/views/simple_message_box_win.cc View 1 chunk +0 lines, -30 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
msw
Hey Scott, please take a look; thanks! John FYI for c/b/hang_monitor/hung_plugin_action.cc
6 years, 10 months ago (2014-02-19 19:42:51 UTC) #1
sky
LGTM
6 years, 10 months ago (2014-02-19 21:23:11 UTC) #2
msw
The CQ bit was checked by msw@chromium.org
6 years, 10 months ago (2014-02-19 21:39:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/172633004/1
6 years, 10 months ago (2014-02-19 21:43:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/172633004/1
6 years, 10 months ago (2014-02-20 00:34:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/172633004/1
6 years, 10 months ago (2014-02-20 03:16:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/172633004/1
6 years, 10 months ago (2014-02-20 08:39:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/172633004/1
6 years, 10 months ago (2014-02-20 12:17:58 UTC) #8
commit-bot: I haz the power
6 years, 10 months ago (2014-02-20 12:50:43 UTC) #9
Message was sent while issue was closed. 
Change committed as 252197

Powered by Google App Engine
This is Rietveld 408576698