content/shell/browser/layout_test/layout_test_push_messaging_service.cc - Issue 1726323002: Have Permission{Manager,Service} use Origin.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/browser/layout_test/layout_test_push_messaging_service.cc

Issue 1726323002: Have Permission{Manager,Service} use Origin. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/shell/browser/layout_test/layout_test_permission_manager.cc ('k') | content/shell/browser/shell_permission_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/browser/layout_test/layout_test_push_messaging_service.cc

diff --git a/content/shell/browser/layout_test/layout_test_push_messaging_service.cc b/content/shell/browser/layout_test/layout_test_push_messaging_service.cc

index 15f63ff1ba5bc495a4740227c3d201e5d6aba620..732bd1cee7507e335551d7fd65a18deb35cf6f4c 100644

--- a/content/shell/browser/layout_test/layout_test_push_messaging_service.cc

+++ b/content/shell/browser/layout_test/layout_test_push_messaging_service.cc

@@ -112,10 +112,13 @@ void LayoutTestPushMessagingService::GetEncryptionInfo(

blink::WebPushPermissionStatus

LayoutTestPushMessagingService::GetPermissionStatus(const GURL& origin,

bool user_visible) {

- return ToWebPushPermissionStatus(LayoutTestContentBrowserClient::Get()

- ->browser_context()

- ->GetPermissionManager()

- ->GetPermissionStatus(PermissionType::PUSH_MESSAGING, origin, origin));

+ const url::Origin actual_origin(origin);

+ return ToWebPushPermissionStatus(

+ LayoutTestContentBrowserClient::Get()

+ ->browser_context()

+ ->GetPermissionManager()

+ ->GetPermissionStatus(PermissionType::PUSH_MESSAGING, actual_origin,

+ actual_origin));

}

bool LayoutTestPushMessagingService::SupportNonVisibleMessages() {