Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Unified Diff: chromecast/browser/cast_permission_manager.cc

Issue 1726323002: Have Permission{Manager,Service} use Origin. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromecast/browser/cast_permission_manager.h ('k') | content/browser/frame_host/render_frame_host_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromecast/browser/cast_permission_manager.cc
diff --git a/chromecast/browser/cast_permission_manager.cc b/chromecast/browser/cast_permission_manager.cc
index eafb652cf5528ef0c2717d440c0f0223026208d1..f9a33729b59cb21024127cabc5037534fc91c00f 100644
--- a/chromecast/browser/cast_permission_manager.cc
+++ b/chromecast/browser/cast_permission_manager.cc
@@ -21,7 +21,7 @@ CastPermissionManager::~CastPermissionManager() {
int CastPermissionManager::RequestPermission(
content::PermissionType permission,
content::RenderFrameHost* render_frame_host,
- const GURL& origin,
+ const url::Origin& origin,
const base::Callback<void(content::mojom::PermissionStatus)>& callback) {
LOG(INFO) << __FUNCTION__ << ": " << static_cast<int>(permission);
callback.Run(content::mojom::PermissionStatus::GRANTED);
@@ -31,7 +31,7 @@ int CastPermissionManager::RequestPermission(
int CastPermissionManager::RequestPermissions(
const std::vector<content::PermissionType>& permissions,
content::RenderFrameHost* render_frame_host,
- const GURL& requesting_origin,
+ const url::Origin& requesting_origin,
const base::Callback<
void(const std::vector<content::mojom::PermissionStatus>&)>& callback) {
callback.Run(std::vector<content::mojom::PermissionStatus>(
@@ -44,28 +44,26 @@ void CastPermissionManager::CancelPermissionRequest(int request_id) {
void CastPermissionManager::ResetPermission(
content::PermissionType permission,
- const GURL& requesting_origin,
- const GURL& embedding_origin) {
-}
+ const url::Origin& requesting_origin,
+ const url::Origin& embedding_origin) {}
content::mojom::PermissionStatus CastPermissionManager::GetPermissionStatus(
content::PermissionType permission,
- const GURL& requesting_origin,
- const GURL& embedding_origin) {
+ const url::Origin& requesting_origin,
+ const url::Origin& embedding_origin) {
LOG(INFO) << __FUNCTION__ << ": " << static_cast<int>(permission);
return content::mojom::PermissionStatus::GRANTED;
}
void CastPermissionManager::RegisterPermissionUsage(
content::PermissionType permission,
- const GURL& requesting_origin,
- const GURL& embedding_origin) {
-}
+ const url::Origin& requesting_origin,
+ const url::Origin& embedding_origin) {}
int CastPermissionManager::SubscribePermissionStatusChange(
content::PermissionType permission,
- const GURL& requesting_origin,
- const GURL& embedding_origin,
+ const url::Origin& requesting_origin,
+ const url::Origin& embedding_origin,
const base::Callback<void(content::mojom::PermissionStatus)>& callback) {
return kNoPendingOperation;
}
« no previous file with comments | « chromecast/browser/cast_permission_manager.h ('k') | content/browser/frame_host/render_frame_host_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698