Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4533)

Unified Diff: chrome/browser/notifications/notification_permission_context.h

Issue 1726323002: Have Permission{Manager,Service} use Origin. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/notifications/notification_permission_context.h
diff --git a/chrome/browser/notifications/notification_permission_context.h b/chrome/browser/notifications/notification_permission_context.h
index 27d9e841d64cd92ec6d51fc12157b45c7323852d..cbccdedcc5cc54c8d6f52e1934a1352c8d1deffc 100644
--- a/chrome/browser/notifications/notification_permission_context.h
+++ b/chrome/browser/notifications/notification_permission_context.h
@@ -9,7 +9,10 @@
#include "chrome/browser/permissions/permission_context_base.h"
#include "components/content_settings/core/common/content_settings.h"
-class GURL;
+namespace url {
+class Origin;
+}
+
class Profile;
class NotificationPermissionContext : public PermissionContextBase {
@@ -18,8 +21,8 @@ class NotificationPermissionContext : public PermissionContextBase {
~NotificationPermissionContext() override;
// PermissionContextBase implementation.
- void ResetPermission(const GURL& requesting_origin,
- const GURL& embedder_origin) override;
+ void ResetPermission(const url::Origin& requesting_origin,
+ const url::Origin& embedder_origin) override;
void CancelPermissionRequest(content::WebContents* web_contents,
const PermissionRequestID& id) override;
@@ -32,11 +35,11 @@ class NotificationPermissionContext : public PermissionContextBase {
// PermissionContextBase implementation.
void DecidePermission(content::WebContents* web_contents,
const PermissionRequestID& id,
- const GURL& requesting_origin,
- const GURL& embedding_origin,
+ const url::Origin& requesting_origin,
+ const url::Origin& embedding_origin,
const BrowserPermissionCallback& callback) override;
- void UpdateContentSetting(const GURL& requesting_origin,
- const GURL& embedder_origin,
+ void UpdateContentSetting(const url::Origin& requesting_origin,
+ const url::Origin& embedder_origin,
ContentSetting content_setting) override;
bool IsRestrictedToSecureOrigins() const override;

Powered by Google App Engine
This is Rietveld 408576698