Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2849)

Unified Diff: chrome/browser/media/midi_permission_context_unittest.cc

Issue 1726323002: Have Permission{Manager,Service} use Origin. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/midi_permission_context_unittest.cc
diff --git a/chrome/browser/media/midi_permission_context_unittest.cc b/chrome/browser/media/midi_permission_context_unittest.cc
index 1184b27ea09329535696ed439c40632d15c14c47..96354e3d623bb109132fe75ba19e86b15db4c582 100644
--- a/chrome/browser/media/midi_permission_context_unittest.cc
+++ b/chrome/browser/media/midi_permission_context_unittest.cc
@@ -56,7 +56,7 @@ class TestPermissionContext : public MidiPermissionContext {
protected:
void UpdateTabContext(const PermissionRequestID& id,
- const GURL& requesting_origin,
+ const url::Origin& requesting_origin,
bool allowed) override {
tab_context_updated_ = true;
}
@@ -90,15 +90,16 @@ class MidiPermissionContextTests : public ChromeRenderViewHostTestHarness {
// Web MIDI permission should be denied for insecure origin.
TEST_F(MidiPermissionContextTests, TestInsecureRequestingUrl) {
TestPermissionContext permission_context(profile());
- GURL url("http://www.example.com");
+ const GURL url("http://www.example.com");
content::WebContentsTester::For(web_contents())->NavigateAndCommit(url);
const PermissionRequestID id(
web_contents()->GetRenderProcessHost()->GetID(),
web_contents()->GetMainFrame()->GetRoutingID(),
-1);
+ const url::Origin origin(url);
permission_context.RequestPermission(
- web_contents(), id, url,
+ web_contents(), id, origin,
base::Bind(&TestPermissionContext::TrackPermissionDecision,
base::Unretained(&permission_context)));
@@ -141,8 +142,10 @@ TEST_F(MidiPermissionContextTests, TestInsecureQueryingUrl) {
CONTENT_SETTINGS_TYPE_MIDI_SYSEX,
std::string()));
+ const url::Origin insecure_origin(insecure_url);
+ const url::Origin secure_origin(secure_url);
EXPECT_EQ(CONTENT_SETTING_BLOCK, permission_context.GetPermissionStatus(
- insecure_url, insecure_url));
+ insecure_origin, insecure_origin));
EXPECT_EQ(CONTENT_SETTING_BLOCK, permission_context.GetPermissionStatus(
- insecure_url, secure_url));
+ insecure_origin, secure_origin));
}
« no previous file with comments | « chrome/browser/media/midi_permission_context.cc ('k') | chrome/browser/media/protected_media_identifier_permission_context.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698