chrome/browser/background_sync/background_sync_permission_context.cc - Issue 1726323002: Have Permission{Manager,Service} use Origin.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/background_sync/background_sync_permission_context.cc

Issue 1726323002: Have Permission{Manager,Service} use Origin. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/background_sync/background_sync_permission_context.h ('k') | chrome/browser/background_sync/background_sync_permission_context_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/background_sync/background_sync_permission_context.cc

diff --git a/chrome/browser/background_sync/background_sync_permission_context.cc b/chrome/browser/background_sync/background_sync_permission_context.cc

index 2faca4508fddfddcd2b7758b40413035d9b9c579..6091174902c7042284332298b2bc6d07be6d522b 100644

--- a/chrome/browser/background_sync/background_sync_permission_context.cc

+++ b/chrome/browser/background_sync/background_sync_permission_context.cc

@@ -25,8 +25,8 @@ void BackgroundSyncPermissionContext::CancelPermissionRequest(

void BackgroundSyncPermissionContext::DecidePermission(

content::WebContents* web_contents,

const PermissionRequestID& id,

- const GURL& requesting_origin,

- const GURL& embedding_origin,

+ const url::Origin& requesting_origin,

+ const url::Origin& embedding_origin,

const BrowserPermissionCallback& callback) {

// The user should never be prompted to authorize background sync.

NOTREACHED();