Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1155)

Unified Diff: content/shell/browser/shell_permission_manager.h

Issue 1726323002: Have Permission{Manager,Service} use Origin. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Clarify and test Origin.empty_. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/shell/browser/shell_permission_manager.h
diff --git a/content/shell/browser/shell_permission_manager.h b/content/shell/browser/shell_permission_manager.h
index 480bd35a5d1bcf664a7b2fb2864198f6d2a26784..c0032703ab2fdb2d6147570009ad5f29be28390f 100644
--- a/content/shell/browser/shell_permission_manager.h
+++ b/content/shell/browser/shell_permission_manager.h
@@ -9,6 +9,10 @@
#include "base/macros.h"
#include "content/public/browser/permission_manager.h"
+namespace url {
+class Origin;
+}
+
namespace content {
class ShellPermissionManager : public PermissionManager {
@@ -20,28 +24,29 @@ class ShellPermissionManager : public PermissionManager {
int RequestPermission(
PermissionType permission,
RenderFrameHost* render_frame_host,
- const GURL& requesting_origin,
+ const url::Origin& requesting_origin,
const base::Callback<void(PermissionStatus)>& callback) override;
int RequestPermissions(
const std::vector<PermissionType>& permission,
RenderFrameHost* render_frame_host,
- const GURL& requesting_origin,
- const base::Callback<void(
- const std::vector<PermissionStatus>&)>& callback) override;
+ const url::Origin& requesting_origin,
+ const base::Callback<void(const std::vector<PermissionStatus>&)>&
+ callback) override;
void CancelPermissionRequest(int request_id) override;
void ResetPermission(PermissionType permission,
- const GURL& requesting_origin,
- const GURL& embedding_origin) override;
- PermissionStatus GetPermissionStatus(PermissionType permission,
- const GURL& requesting_origin,
- const GURL& embedding_origin) override;
+ const url::Origin& requesting_origin,
+ const url::Origin& embedding_origin) override;
+ PermissionStatus GetPermissionStatus(
+ PermissionType permission,
+ const url::Origin& requesting_origin,
+ const url::Origin& embedding_origin) override;
void RegisterPermissionUsage(PermissionType permission,
- const GURL& requesting_origin,
- const GURL& embedding_origin) override;
+ const url::Origin& requesting_origin,
+ const url::Origin& embedding_origin) override;
int SubscribePermissionStatusChange(
PermissionType permission,
- const GURL& requesting_origin,
- const GURL& embedding_origin,
+ const url::Origin& requesting_origin,
+ const url::Origin& embedding_origin,
const base::Callback<void(PermissionStatus)>& callback) override;
void UnsubscribePermissionStatusChange(int subscription_id) override;

Powered by Google App Engine
This is Rietveld 408576698