Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Unified Diff: content/browser/push_messaging/push_messaging_message_filter.cc

Issue 1726323002: Have Permission{Manager,Service} use Origin. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Clarify and test Origin.empty_. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/push_messaging/push_messaging_message_filter.cc
diff --git a/content/browser/push_messaging/push_messaging_message_filter.cc b/content/browser/push_messaging/push_messaging_message_filter.cc
index a2eb8959eeef2e006ce40bbf68fc73b0a89f7182..cb3192a4daa305d2e34ec854e4665aec8352d550 100644
--- a/content/browser/push_messaging/push_messaging_message_filter.cc
+++ b/content/browser/push_messaging/push_messaging_message_filter.cc
@@ -29,6 +29,7 @@
#include "content/public/common/console_message_level.h"
#include "content/public/common/push_messaging_status.h"
#include "third_party/WebKit/public/platform/modules/push_messaging/WebPushPermissionStatus.h"
+#include "url/origin.h"
namespace content {
@@ -428,7 +429,7 @@ void PushMessagingMessageFilter::Core::RegisterOnUI(
->GetPermissionManager()
->RequestPermission(
PermissionType::PUSH_MESSAGING, render_frame_host,
- data.requesting_origin,
+ url::Origin(data.requesting_origin),
base::Bind(&PushMessagingMessageFilter::Core::
DidRequestPermissionInIncognito,
weak_factory_ui_to_ui_.GetWeakPtr(), data));

Powered by Google App Engine
This is Rietveld 408576698